fix null coalescent operator expression#518
fix null coalescent operator expression#518mjauvin merged 1 commit intowintercms:wip/1.2from mjauvin:fix-js-filter
Conversation
mjauvin
commented
Mar 30, 2022
- add parenthesis around expression, was breaking when compiling the js asset without this
- recompile all js assets
…rator - recompile all js assets
bennothommo
left a comment
There was a problem hiding this comment.
Looks fine to me, if it's all tested and works, then feel free to merge.
@mjauvin you're right, null coalesce is definitely a valid operator, so the problem is with the asset compiler. I don't think the same problem would occur with the new Mix compiler.
|
This might be worth reporting to wikimedia (I believe the JS minifier is now using https://github.com/wikimedia/minify). |
|
@mjauvin are you able to report the issue to wikimedia? |
|
@LukeTowers I tried to open an issue, but couldn't find a way without creating a developper account. Do you have such an account yourself? |
|
No, you'd have to create one. |
|
Man, forget it. Ever heard of "La maison des fous" ? You get bounced all over the place and never end-up in the right place... this is MADENING. Why can't they have github issue enabled and that's it? |
|
Issue opened at wikimedia: |