fix: incorrect meta-migration v16#1640
Merged
SimonThormeyer merged 2 commits intomainfrom Dec 2, 2025
Merged
Conversation
0631cb3 to
a09009b
Compare
coriolinus
approved these changes
Dec 2, 2025
The cargo deny release 0.18.7 broke checks for us
In some cases it might make a difference: in the v16 meta migration, we want to delete a specific credential, however, we deleted credentials by client id instead. This corrects that behavior.
a09009b to
b918537
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases it might make a difference: in the v16 meta migration, we want to delete a specific credential, however, we deleted credentials by client id instead.
This corrects that behavior.
What's new in this PR
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.