Merged
Conversation
fewerner
commented
Dec 3, 2025
coriolinus
reviewed
Dec 3, 2025
Contributor
coriolinus
left a comment
There was a problem hiding this comment.
I really don't like the prevalence of Arc::unwrap_or_clone, given how unnecessary it is. And the changes to Cargo.toml need reverting.
Even so, this is great work, and I'm looking forward to approving it soon.
cfef15e to
9aa5d44
Compare
coriolinus
approved these changes
Dec 4, 2025
Note that we get conversion between FFI and crypto without to_cc/from_cc
Instead of cloning an inner value of an Arc we should use .as_ref() to retrieve it. For ClientId we then implement AsRef<core_crypto::ClientIdRef> which allows for a zero-copy conversion of core_crypto_ffi::Clientd to core_crypto::ClientIdRef and thus to core_crypto::ClientId. We also change the function signature of get_device_ids() to accept a slice of ClientIdRefs.
9aa5d44 to
1664ff1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
This PR removes any MaybeArc implementation since we now always use Arc because we always use uniffi.
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.