feat: use kotlin timestamp instead of the java generated one#1650
feat: use kotlin timestamp instead of the java generated one#1650istankovic merged 1 commit intowireapp:mainfrom
Conversation
|
TOML formatting check fails, please use taplo to fix it: https://github.com/wireapp/core-crypto?tab=readme-ov-file#toml |
|
Could you please drop the unnecessary merge commit and fold e318b39 into the first commit that introduced the changes? |
bb9033d to
7c16be1
Compare
7c16be1 to
c29e7fd
Compare
|
@MohamadJaara I see this type being added, but where is it actually used? |
3fd15e0 to
d588798
Compare
|
@MohamadJaara could you please fold the second commit into the first one? |
259dbfd to
a1f2dfb
Compare
|
@istankovic, @coriolinus is there any changes needed to this PR or it can be merged? |
coriolinus
left a comment
There was a problem hiding this comment.
Looks good, thanks for documenting what the target language mappings all are! I very much like that it allows us to stop using bare numbers as "number of seconds or milliseconds or something after the epoch"; that kind of interface is always fragile.
a1f2dfb to
d84d860
Compare
What's new in this PR
fully support apple targets in kalium we need to have a unified interface between the android/kmp bindings
this PR adds a custom type converted to the jvm/android bindings to use kotlin time class instead of the java one
it should add no changes to wasm/ios bindings only for kotlin
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.