Skip to content

feat: use kotlin timestamp instead of the java generated one#1650

Merged
istankovic merged 1 commit intowireapp:mainfrom
MohamadJaara:mo/feat/custom-time-type
Dec 19, 2025
Merged

feat: use kotlin timestamp instead of the java generated one#1650
istankovic merged 1 commit intowireapp:mainfrom
MohamadJaara:mo/feat/custom-time-type

Conversation

@MohamadJaara
Copy link
Member

What's new in this PR

fully support apple targets in kalium we need to have a unified interface between the android/kmp bindings
this PR adds a custom type converted to the jvm/android bindings to use kotlin time class instead of the java one
it should add no changes to wasm/ios bindings only for kotlin


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara requested a review from a team December 4, 2025 09:17
@istankovic
Copy link
Member

TOML formatting check fails, please use taplo to fix it: https://github.com/wireapp/core-crypto?tab=readme-ov-file#toml

@istankovic
Copy link
Member

Could you please drop the unnecessary merge commit and fold e318b39 into the first commit that introduced the changes?

@MohamadJaara MohamadJaara force-pushed the mo/feat/custom-time-type branch from bb9033d to 7c16be1 Compare December 4, 2025 10:05
@MohamadJaara MohamadJaara force-pushed the mo/feat/custom-time-type branch from 7c16be1 to c29e7fd Compare December 4, 2025 10:30
@MohamadJaara MohamadJaara added DO NOT MERGE This cannot get merged temporarily api:breaking This contains breaking changes to the public-facing API labels Dec 4, 2025
@istankovic
Copy link
Member

@MohamadJaara I see this type being added, but where is it actually used?

@MohamadJaara MohamadJaara force-pushed the mo/feat/custom-time-type branch 5 times, most recently from 3fd15e0 to d588798 Compare December 4, 2025 22:27
@MohamadJaara MohamadJaara removed the DO NOT MERGE This cannot get merged temporarily label Dec 4, 2025
@istankovic
Copy link
Member

@MohamadJaara could you please fold the second commit into the first one?

@MohamadJaara MohamadJaara force-pushed the mo/feat/custom-time-type branch from 259dbfd to a1f2dfb Compare December 5, 2025 08:44
@istankovic istankovic changed the title feat: use kotlin timestapm instead of the java generated one feat: use kotlin timestamp instead of the java generated one Dec 5, 2025
@MohamadJaara
Copy link
Member Author

@istankovic, @coriolinus is there any changes needed to this PR or it can be merged?

Copy link
Contributor

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for documenting what the target language mappings all are! I very much like that it allows us to stop using bare numbers as "number of seconds or milliseconds or something after the epoch"; that kind of interface is always fragile.

@istankovic istankovic force-pushed the mo/feat/custom-time-type branch from a1f2dfb to d84d860 Compare December 19, 2025 09:19
@istankovic istankovic merged commit d84d860 into wireapp:main Dec 19, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api:breaking This contains breaking changes to the public-facing API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants