chore: move pki_env out of crypto [WPB-19579]#1804
Merged
istankovic merged 9 commits intomainfrom Jan 30, 2026
Merged
Conversation
At least for the time being.
It's being used only by the tests in the crypto crate so that's a better place for it.
…l to e2e-identity We cannot proceed without those bits in e2e-identity, we would have a cyclic dependency between crypto and e2e-identity. But more importantly, it absolutely makes sense to have credential validation for a specific credential type in the crate that is all about that credential type.
Some of the error handling code had to be sacrificed a bit, but it's not worth fixing it right now because it is expected that the relevant code is going to be changed considerably later on.
fewerner
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves
PkiEnvironment,PkiEnvironmentHooksand some related code toe2e-identity, where it belongs. It's a necessary step to be able to start work on x509 credential acquisition (WPB-19579).