Skip to content

Comments

feat(apps): system message handling for app access changed in conversations (WPB-21442)#3704

Merged
yamilmedina merged 14 commits intodevelopfrom
yamil/feat/toggle-apsp
Nov 14, 2025
Merged

feat(apps): system message handling for app access changed in conversations (WPB-21442)#3704
yamilmedina merged 14 commits intodevelopfrom
yamil/feat/toggle-apsp

Conversation

@yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Nov 13, 2025

StoryWPB-21442 [Android] [Integration] Toggle Apps in Conversation Flow


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Implement the changes for adding a new system message when the apps are enabled or disabled in a conversation.

Solutions

  • Creates a new use case that enables the toggling of apps specifically by reusing the access change use case.
  • Adds new table for system message of apps
  • Adds migration code

Dependencies (Optional)

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Attachments (Optional)

Screenshot_20251113_164126

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

Test Results

0 tests   - 4 069   0 ✅  - 3 958   0s ⏱️ - 5m 29s
0 suites  -   686   0 💤  -   111 
0 files    -   686   0 ❌ ±    0 

Results for commit 2254554. ± Comparison against base commit 5226269.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

🐰 Bencher Report

Branchyamil/feat/toggle-apsp
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
684.75 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
413,055.33 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,511,292.47 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
29,036.77 µs
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 61.53846% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.35%. Comparing base (d984d18) to head (2551bde).

Files with missing lines Patch % Lines
...ation/NewGroupConversationSystemMessagesCreator.kt 14.28% 12 Missing ⚠️
.../persistence/dao/message/MessageInsertExtension.kt 12.50% 6 Missing and 1 partial ⚠️
...e/kalium/persistence/dao/message/MessageDAOImpl.kt 0.00% 6 Missing ⚠️
...tlin/com/wire/kalium/logic/data/message/Message.kt 0.00% 3 Missing ⚠️
...om/wire/kalium/logic/data/message/MessageMapper.kt 0.00% 3 Missing ⚠️
...um/logic/feature/conversation/ConversationScope.kt 0.00% 3 Missing ⚠️
.../receiver/conversation/AccessUpdateEventHandler.kt 85.71% 0 Missing and 3 partials ⚠️
...re/kalium/persistence/dao/message/MessageMapper.kt 0.00% 3 Missing ⚠️
...kalium/logic/data/message/PersistMessageUseCase.kt 0.00% 2 Missing ⚠️
...m/wire/kalium/logic/data/message/MessageContent.kt 66.66% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3704      +/-   ##
===========================================
- Coverage    57.36%   57.35%   -0.01%     
===========================================
  Files         1788     1790       +2     
  Lines        59548    59741     +193     
  Branches      5807     5825      +18     
===========================================
+ Hits         34159    34264     +105     
- Misses       22960    23044      +84     
- Partials      2429     2433       +4     
Files with missing lines Coverage Δ
...c/data/conversation/ConversationGroupRepository.kt 91.53% <100.00%> (+0.11%) ⬆️
...kalium/logic/data/message/SystemMessageInserter.kt 22.38% <100.00%> (+22.38%) ⬆️
...onversation/UpdateConversationAccessRoleUseCase.kt 93.75% <100.00%> (ø)
...n/apps/ChangeAccessForAppsInConversationUseCase.kt 100.00% <100.00%> (ø)
...ceiver/conversation/NewConversationEventHandler.kt 96.55% <100.00%> (+0.32%) ⬆️
...tlin/com/wire/kalium/persistence/db/TableMapper.kt 100.00% <100.00%> (ø)
.../wire/kalium/persistence/db/UserDatabaseBuilder.kt 77.22% <100.00%> (+0.12%) ⬆️
...m/wire/kalium/logic/data/message/MessageContent.kt 43.79% <66.66%> (+0.25%) ⬆️
...authenticated/conversation/ConversationResponse.kt 90.56% <0.00%> (-0.58%) ⬇️
...re/kalium/persistence/dao/message/MessageEntity.kt 77.03% <66.66%> (-0.28%) ⬇️
... and 9 more

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d984d18...2551bde. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@yamilmedina yamilmedina added this pull request to the merge queue Nov 14, 2025
@yamilmedina yamilmedina removed this pull request from the merge queue due to a manual request Nov 14, 2025
@sonarqubecloud
Copy link

@yamilmedina yamilmedina added this pull request to the merge queue Nov 14, 2025
@yamilmedina yamilmedina removed this pull request from the merge queue due to a manual request Nov 14, 2025
@yamilmedina yamilmedina added this pull request to the merge queue Nov 14, 2025
Merged via the queue into develop with commit 4aa76ec Nov 14, 2025
24 checks passed
@yamilmedina yamilmedina deleted the yamil/feat/toggle-apsp branch November 14, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants