feat: retrieve last message preview for conversation list (WPB-21093) #3721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # persistence/src/commonMain/db_user/migrations/121.sqm
Contributor
Contributor
|
Bencher Report| Branch | last-message-preview |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 685.71 µs |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 593,742.30 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,519,307.85 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 27,207.89 µs |
|
ohassine
changed the title
MohamadJaara
requested changes
Nov 21, 2025
Comment on lines
+69
to
+80
| LEFT JOIN ( | ||
| SELECT | ||
| message_id, | ||
| conversation_id, | ||
| CASE | ||
| WHEN COUNT(DISTINCT asset_mime_type) = 1 THEN MIN(asset_mime_type) | ||
| ELSE NULL | ||
| END AS asset_mime_type, | ||
| COUNT(*) attachments_count | ||
| FROM MessageAttachments | ||
| GROUP BY message_id, conversation_id | ||
| ) AS AttachmentsContent ON LastMessage.message_id = AttachmentsContent.message_id AND LastMessage.conversation_id = AttachmentsContent.conversation_id |
Member
There was a problem hiding this comment.
can you please provide some benchmark info about the effect of this join when there are multiple conversations with many assets as last message
Contributor
|
This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Handle MULTIPART type and retrieve last message preview to be shown in conversation list based on number of attachements and content type.
For:
If the user received a mix of files and images/video/audio
We show : "username shared X files."
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.