feat: Draft preview for multipart type message #3728
Conversation
github-actions
bot
added
🚨 Potential breaking changes
👕 size: XL
type: feature ✨
labels
|
| @@ -0,0 +1,109 @@ | |||
| -- This migration updates the ConversationDetailsWithEvents view to include a count of draft attachments. | |||
| DROP VIEW IF EXISTS ConversationDetailsWithEvents; | |||
|
|
|||
There was a problem hiding this comment.
Why 123.sqm and 122.sqm? I see that ConversationDetailsWithEvents is being recreated in both migrations.
| } | ||
|
|
||
| data class Draft(val message: String) : MessagePreviewContent | ||
| data class Draft(val message: String?, val attachmentType: String?, val attachmentsCount: Int) : MessagePreviewContent |
There was a problem hiding this comment.
What are the possible values of attachmentType? Maybe this could be more strongly typed? Something like an enum? Is it mimetype? What about when there are multiple attachments with different types?
| import kotlin.test.assertEquals | ||
| import kotlin.test.assertIs | ||
|
|
||
| class LastMessageListTest: BaseDatabaseTest() { |
There was a problem hiding this comment.
Should this test suite be deleted?
I'd argue it would be nice to add tests to the new feature.
|
This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore. |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Support draft preview for multipart type message to be used in conversation list
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.