-
Notifications
You must be signed in to change notification settings - Fork 7
refactor(api-contracts): create common contracts for public use cases - pt1. kdocs (WPB-21911) #3794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api-contracts): create common contracts for public use cases - pt1. kdocs (WPB-21911) #3794
Conversation
|
| Branch | yamil/refactor/replace-either-for-results |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 667.02 µs |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 584,740.07 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,353,256.06 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 25,915.49 µs |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3794 +/- ##
===========================================
- Coverage 60.04% 60.03% -0.02%
===========================================
Files 1823 1823
Lines 58046 58051 +5
Branches 6318 6318
===========================================
- Hits 34852 34849 -3
- Misses 20325 20330 +5
- Partials 2869 2872 +3
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
In order to continue Kalium adoption on other platforms and to make it a first class lib. We need to provide standardization.
Currently, the architectural fitness functions we use are flawed.
Issues
Solutions
Testing
Test Coverage (Optional)
How to Test
Test under
everyPublicUseCaseInterfaceHasKDocsandeveryPublicUseCaseClassHasKDocsshould be green.PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.