-
Notifications
You must be signed in to change notification settings - Fork 9
feat(nomad devices): batched fetch messages per convo - pagination logic for request of older msgs - pt2 (WPB-24278) #3991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
204c41c
feat: batched fetch add new endpoint and requests/response mapping
yamilmedina e3aeece
feat: add paging coordinator for in mem state management and fetch mo…
yamilmedina 75eefdb
fix: compute correctly last page boundary and more logs for debug
yamilmedina aca7f13
feat: change approach, ui triggered end item refill call
yamilmedina 50712ab
remove leftovers
yamilmedina a7b5b1c
extract interface for usecase
yamilmedina bf609ac
detekt issues fixes
yamilmedina c8fdb22
use constant for query param
yamilmedina e462009
Merge branch 'feat/nomad/paging/pt1' into feat/nomad/pagination-convos
yamilmedina 88d8db9
Merge branch 'develop' into feat/nomad/pagination-convos
yamilmedina 3e769b0
address pr comment, query table directly
yamilmedina 0535459
fix: nomadMessagePagingCoordinator property as getter to get fresh in…
yamilmedina 87199f8
Merge branch 'develop' into feat/nomad/pagination-convos
MohamadJaara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
...lin/com/wire/kalium/logic/feature/message/FetchOlderNomadMessagesByConversationUseCase.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| * Wire | ||
| * Copyright (C) 2026 Wire Swiss GmbH | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see http://www.gnu.org/licenses/. | ||
| */ | ||
|
|
||
| package com.wire.kalium.logic.feature.message | ||
|
|
||
| import com.wire.kalium.logic.data.id.ConversationId | ||
| import com.wire.kalium.logic.data.message.MessageRepository | ||
| import com.wire.kalium.util.KaliumDispatcher | ||
| import com.wire.kalium.util.KaliumDispatcherImpl | ||
| import kotlinx.coroutines.withContext | ||
|
|
||
| public interface FetchOlderNomadMessagesByConversationUseCase { | ||
| /** | ||
| * Fetches older messages for a given conversation in a remote data source and stores them in the local database. | ||
| * This is typically used when the user scrolls up in the message list we want to load more messages from the past. | ||
| */ | ||
| public suspend operator fun invoke( | ||
| conversationId: ConversationId, | ||
| pageSize: Int = DEFAULT_PAGE_SIZE, | ||
| ) | ||
|
|
||
| private companion object { | ||
| const val DEFAULT_PAGE_SIZE = 50 | ||
| } | ||
| } | ||
|
|
||
| internal class FetchOlderNomadMessagesByConversationUseCaseImpl( | ||
| private val dispatcher: KaliumDispatcher = KaliumDispatcherImpl, | ||
| private val messageRepository: MessageRepository, | ||
| ) : FetchOlderNomadMessagesByConversationUseCase { | ||
|
|
||
| override suspend operator fun invoke( | ||
| conversationId: ConversationId, | ||
| pageSize: Int, | ||
| ): Unit = withContext(dispatcher.default) { | ||
| messageRepository.extensions.fetchOlderNomadMessagesByConversationId( | ||
| conversationId = conversationId, | ||
| pageSize = pageSize, | ||
| ) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.