Skip to content

Conversation

@istankovic
Copy link
Member

It's not really useful and just adds noise.

It's not really useful and just adds noise.
@istankovic istankovic requested a review from a team as a code owner December 13, 2024 15:50
@coriolinus
Copy link
Contributor

This looks identical to what we're using in core-crypto, where it's probably more useful than harmful from what I've seen. What makes it just noise in this repo?

(If the answer is "everyone ignores it", then probably we should alter our behavior instead of removing the template.)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.03%. Comparing base (92184e1) to head (6c11137).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   80.03%   80.03%           
=======================================
  Files          49       49           
  Lines        4323     4323           
=======================================
  Hits         3460     3460           
  Misses        863      863           

@istankovic
Copy link
Member Author

istankovic commented Dec 13, 2024

(If the answer is "everyone ignores it", then probably we should alter our behavior instead of removing the template.)

To quote me after seeing another case of just leaving the template as-is:

Whenever I see some text, I try reading it and then I quickly realize "oh, it's just the PR template".
Would be much better if it were just empty -- then I would know the author didn't write anything.
Sometimes the title is also sufficient, which is totally fine. But with this prose, I have to always deliberately skip over it and make sure I haven't missed something that was added by the author.

It's about signal-to-noise ratio. Once the entire team is onboard with the process, the template becomes a chore, rather than something useful, which makes people just leave it. Once you know the process, it's just superfluous.
This is why I'd rather prefer seeing empty description than the template contents.

And yes, I'd suggest to do the same in core-crypto.

@istankovic
Copy link
Member Author

The preference seems to be for the template to stay, so let's close this.

@istankovic istankovic closed this Dec 16, 2024
@istankovic istankovic deleted the ivan/remove-pr-template branch December 16, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants