test: support running e2e tests via podman and on macOS#381
Merged
SimonThormeyer merged 5 commits intomainfrom Aug 18, 2025
Merged
test: support running e2e tests via podman and on macOS#381SimonThormeyer merged 5 commits intomainfrom
SimonThormeyer merged 5 commits intomainfrom
Conversation
SimonThormeyer
force-pushed
the
simon/ci/fix-tests-on-macOS-WPB-19213
branch
2 times, most recently
from
7c5eed1 to
9bf5328
Compare
SimonThormeyer
changed the title
coriolinus
reviewed
Aug 18, 2025
Contributor
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
Guess tests are not currently passing, so abandoning the review for now.
SimonThormeyer
force-pushed
the
simon/ci/fix-tests-on-macOS-WPB-19213
branch
3 times, most recently
from
4663817 to
b9e3d81
Compare
istankovic
reviewed
Aug 18, 2025
istankovic
reviewed
Aug 18, 2025
coriolinus
approved these changes
Aug 18, 2025
This allows running a specific test with the wrapper script.
This allows displaying urls with the acme provisioner
To support this, various changes had to me made: - instead of using the `with_copy_to()` feature of test containers, manually write the intermediate template file to the destination - when running `step ca init`, wait for "Your PKI is ready to go." output on stderr - stop running `chmod` on the `ca.json` file - make the final acme startup command write its stdout to a file and its stderr to stdout This changeset seems to be the fragile mininal changeset that doesn't break anything on macOS with podman and GitHub CI.
SimonThormeyer
force-pushed
the
simon/ci/fix-tests-on-macOS-WPB-19213
branch
from
39e6b27 to
e0e6ff1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
See commit messages
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.