Merged
Conversation
coriolinus
reviewed
Aug 18, 2025
istankovic
reviewed
Aug 18, 2025
fewerner
force-pushed
the
felix/ci/fix-warnings
branch
2 times, most recently
from
c9085b5 to
107fab3
Compare
coriolinus
approved these changes
Aug 18, 2025
Most of these warnings were broken intra-doc links, e.g. function arguments can't be linked and refences have to match correct import.
wasm-bindgen-test defines wasm_bindgen_unstable_test_coverage internally. However, cargo check does not recognize this definition and reports a warning. We configure cargo to allow this specific definition to be missing to fix the warning.
The only reference to this function is under the added config. Which results in dead code for compilations with wasm target. We add the compilation config to fix this.
enrollments() returns a vector of four values where only two are used for wasm builds. To not overcomplicate the conditional compilation or refactor the entire module, we allow unused variables at this point.
The rustflags will only affect build process which means that it only affects cargo check.
fewerner
force-pushed
the
felix/ci/fix-warnings
branch
from
107fab3 to
b5d71d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
This PR fixes warnings that occured during cargo doc and cargo check. It also lets both tools fail on warnings during CI.
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.