Merged
Conversation
Previously two teams were considered equal if one of them were None, this is no longer the case. This mainly affects the the generation of the dpop access token which is a function which executes on the wire-server. The effect is that it's no longer allowed for a client which belongs to a team to omit the team parameter when enrolling into e2ei.
is allowed to be omitted when generating a dpop access token. It's now only allowed to be omitted when the user in question also isn't associated with a team.
This function is exclusively used in the tests and previously the team was defaulting to always be None, which will now fail because of to the more strict team comparision introduced in the previous commit.
typfel
force-pushed
the
fix/more-strict-team-validation
branch
from
008728d to
1c552aa
Compare
SimonThormeyer
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.