fix: attachments menu blends with background [WPB-15102]#3761
Merged
saleniuk merged 5 commits intorelease/candidatefrom Dec 20, 2024
Merged
fix: attachments menu blends with background [WPB-15102]#3761saleniuk merged 5 commits intorelease/candidatefrom
saleniuk merged 5 commits intorelease/candidatefrom
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3761 +/- ##
=====================================================
- Coverage 45.73% 45.69% -0.04%
=====================================================
Files 473 473
Lines 16094 16108 +14
Branches 2717 2718 +1
=====================================================
Hits 7361 7361
- Misses 7972 7986 +14
Partials 761 761
Continue to review full report in Codecov by Sentry.
|
Contributor
|
Built wire-android-staging-compat-pr-3761.apk is available for download |
MohamadJaara
approved these changes
Dec 20, 2024
vitorhugods
approved these changes
Dec 20, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Attachments menu matches the background color of the conversation screen, making it difficult to distinguish the overlay from the background.
Solutions
Rearrange some surface colors, add border to the attachments menu in the way so that it is drawn properly even during animations.
Testing
How to Test
Open attachments menu on light and dark mode.
Attachments (Optional)
animation_10x_slower.mp4