fix: allowing empty team name when migrating [WPB-15092]#3763
Merged
saleniuk merged 1 commit intorelease/candidatefrom Dec 20, 2024
Merged
fix: allowing empty team name when migrating [WPB-15092]#3763saleniuk merged 1 commit intorelease/candidatefrom
saleniuk merged 1 commit intorelease/candidatefrom
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3763 +/- ##
==================================================
Coverage 45.73% 45.73%
==================================================
Files 473 473
Lines 16094 16094
Branches 2717 2717
==================================================
Hits 7361 7361
Misses 7972 7972
Partials 761 761
Continue to review full report in Codecov by Sentry.
|
Contributor
|
Built wire-android-staging-compat-pr-3763.apk is available for download |
vitorhugods
approved these changes
Dec 20, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When a personal user migrates to a team account, the "Your Team" input field allows the user to enter only spaces as the team name and proceed with registration. This results in invalid or meaningless team names, which should not be permitted.
Solutions
Modify the check for enabling "continue" button to also check whether the name is not blank.
Trim all excessive spaces at the start of end of the name.
Testing
Test Coverage (Optional)
How to Test
Steps to Reproduce:
-Log in to the Android app as a personal user on the Anta BE environment.
-Start the process to migrate to a team account.
-In the Team Name Overlay, enter only spaces (e.g., " ") in the "Your Team" input field.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.