fix: adjustments for short signature names (WPB-15188)#3768
Merged
yamilmedina merged 1 commit intorelease/candidatefrom Dec 27, 2024
Merged
fix: adjustments for short signature names (WPB-15188)#3768yamilmedina merged 1 commit intorelease/candidatefrom
yamilmedina merged 1 commit intorelease/candidatefrom
Conversation
|
MohamadJaara
approved these changes
Dec 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3768 +/- ##
=====================================================
- Coverage 45.69% 45.69% -0.01%
=====================================================
Files 473 473
Lines 16108 16115 +7
Branches 2718 2724 +6
=====================================================
+ Hits 7361 7363 +2
Misses 7986 7986
- Partials 761 766 +5
Continue to review full report in Codecov by Sentry.
|
Contributor
|
Built wire-android-staging-compat-pr-3768.apk is available for download |
sergeibakhtiarov
approved these changes
Dec 27, 2024
7 tasks
yamilmedina
added a commit
that referenced
this pull request
Jan 9, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We show now the ciphersuite entry in device details. But currently we show the full string.
We should trim it, to make it easy for the users.
Causes (Optional)
Not previous alignment on this full vs. short name.
Solutions
Implement following suit of what was implemented on other platforms.
I.e.:
Testing
Test Coverage (Optional)
How to Test
Have a MLS client and see on device details the signature
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.