feat: open team migration on creating channel upgrade [WPB-17057]#3998
Merged
MohamadJaara merged 3 commits intodevelopfrom Apr 24, 2025
Merged
Conversation
|
Contributor
|
Built wire-android-staging-compat-pr-3998.apk is available for download |
Contributor
|
Built wire-android-dev-debug-pr-3998.apk is available for download |
MohamadJaara
approved these changes
Apr 23, 2025
Garzas
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Currently, when personal users try to create a channel, they see an Upgrade button (since this feature is not available to them). When they click on this button, a "Create Wire Team" popup appears. If they continue, they are redirected to the team registration flow.
This PR changes this behaviour, according to the recent acceptance criteria, to redirect to the personal to team migration flow instead.
Also, our team migration flow had nested
NavHostand their navigation graph was separated from the main navigation graph which could lead to errors (using different Navigator for instance) and we agreed to not have other nestedNavHosts. This PR removes the nestedNavHostand screen that contained it, moves this subgraph to be part of main graph and cleans up the styling so that no scrim colour applied to the Activity's background is needed (status bar icons were hidden because of that) but instead the solution from the new login with background is reused, so that our subgraphs are more unified.Testing
How to Test
Log in as a personal account, try to create a channel, click on "Create Wire Team" button on a dialog.
Attachments (Optional)
create_channel_upgrade.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.