Skip to content

feat: open team migration on creating channel upgrade [WPB-17057]#3998

Merged
MohamadJaara merged 3 commits intodevelopfrom
feat/open-team-migration-when-upgrading-for-channels
Apr 24, 2025
Merged

feat: open team migration on creating channel upgrade [WPB-17057]#3998
MohamadJaara merged 3 commits intodevelopfrom
feat/open-team-migration-when-upgrading-for-channels

Conversation

@saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Apr 22, 2025

StoryWPB-17057 [Android] - CTA behavior for Personal users when attempting to create a channel


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Currently, when personal users try to create a channel, they see an Upgrade button (since this feature is not available to them). When they click on this button, a "Create Wire Team" popup appears. If they continue, they are redirected to the team registration flow.
This PR changes this behaviour, according to the recent acceptance criteria, to redirect to the personal to team migration flow instead.

Also, our team migration flow had nested NavHost and their navigation graph was separated from the main navigation graph which could lead to errors (using different Navigator for instance) and we agreed to not have other nested NavHosts. This PR removes the nested NavHost and screen that contained it, moves this subgraph to be part of main graph and cleans up the styling so that no scrim colour applied to the Activity's background is needed (status bar icons were hidden because of that) but instead the solution from the new login with background is reused, so that our subgraphs are more unified.

Testing

How to Test

Log in as a personal account, try to create a channel, click on "Create Wire Team" button on a dialog.

Attachments (Optional)

create_channel_upgrade.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3998.apk is available for download

@github-actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3998.apk is available for download

@saleniuk saleniuk requested review from a team, Garzas, alexandreferris, emmaoke-w, mathias-niboulies and ohassine and removed request for a team April 23, 2025 15:26
@MohamadJaara MohamadJaara added this pull request to the merge queue Apr 24, 2025
Merged via the queue into develop with commit d6a3364 Apr 24, 2025
12 of 13 checks passed
@MohamadJaara MohamadJaara deleted the feat/open-team-migration-when-upgrading-for-channels branch April 24, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants