Skip to content

fix: home requirements navigation crashing [WPB-17263]#3999

Merged
MohamadJaara merged 1 commit intodevelopfrom
fix/home-requirements-navigation-crash
Apr 23, 2025
Merged

fix: home requirements navigation crashing [WPB-17263]#3999
MohamadJaara merged 1 commit intodevelopfrom
fix/home-requirements-navigation-crash

Conversation

@saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Apr 23, 2025

BugWPB-17263 [Android] App crashing on startup after upgrade


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

App crashing on navigation command on home screen when checking requirements.

Causes (Optional)

Navigation command executed in wrong lifecycle state.

Solutions

Use a flow with lifecycle-aware collector to ensure navigation command is executed when UI is in valid lifecycle state.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Update to 4.12.1 having expired account session - it should open "register device" screen.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from a team, MohamadJaara, alexandreferris, mathias-niboulies, ohassine and sbakhtiarov and removed request for a team April 23, 2025 09:51
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.54%. Comparing base (e35bdc4) to head (eeee560).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3999      +/-   ##
===========================================
+ Coverage    45.53%   45.54%   +0.01%     
===========================================
  Files          518      518              
  Lines        18044    18048       +4     
  Branches      3032     3032              
===========================================
+ Hits          8216     8220       +4     
  Misses        8977     8977              
  Partials       851      851              
Files with missing lines Coverage Δ
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt 84.48% <100.00%> (+1.14%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35bdc4...eeee560. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MohamadJaara MohamadJaara enabled auto-merge April 23, 2025 10:02
@MohamadJaara MohamadJaara added this pull request to the merge queue Apr 23, 2025
Merged via the queue into develop with commit a73f19f Apr 23, 2025
13 of 14 checks passed
@MohamadJaara MohamadJaara deleted the fix/home-requirements-navigation-crash branch April 23, 2025 10:15
@github-actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3999.apk is available for download

@github-actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3999.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants