fix: home requirements navigation crashing [WPB-17263]#3999
Merged
MohamadJaara merged 1 commit intodevelopfrom Apr 23, 2025
Merged
fix: home requirements navigation crashing [WPB-17263]#3999MohamadJaara merged 1 commit intodevelopfrom
MohamadJaara merged 1 commit intodevelopfrom
Conversation
|
sbakhtiarov
approved these changes
Apr 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3999 +/- ##
===========================================
+ Coverage 45.53% 45.54% +0.01%
===========================================
Files 518 518
Lines 18044 18048 +4
Branches 3032 3032
===========================================
+ Hits 8216 8220 +4
Misses 8977 8977
Partials 851 851
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
|
Built wire-android-staging-compat-pr-3999.apk is available for download |
Contributor
|
Built wire-android-dev-debug-pr-3999.apk is available for download |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
App crashing on navigation command on home screen when checking requirements.
Causes (Optional)
Navigation command executed in wrong lifecycle state.
Solutions
Use a flow with lifecycle-aware collector to ensure navigation command is executed when UI is in valid lifecycle state.
Testing
Test Coverage (Optional)
How to Test
Update to 4.12.1 having expired account session - it should open "register device" screen.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.