Skip to content

chore: remove debug option to lower the the threshold for updating conversation key material [WPB-17354]#4001

Merged
MohamadJaara merged 3 commits intodevelopfrom
fix/the-threshhod-for-ley-material-update
Apr 24, 2025
Merged

chore: remove debug option to lower the the threshold for updating conversation key material [WPB-17354]#4001
MohamadJaara merged 3 commits intodevelopfrom
fix/the-threshhod-for-ley-material-update

Conversation

@MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Apr 24, 2025

TaskWPB-17354 [Android] remove mls debug option for internal builds


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

KEYING_MATERIAL_UPDATE_THRESHOLD_LOW is used in internal builds is not needed anymore

Causes (Optional)

was added during the development time of MLS and not it is not needed anymore

Solutions

nuke it

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the title chore: remove debug option to lower the the threshold for updating conversation key material chore: remove debug option to lower the the threshold for updating conversation key material [WPB-17354] Apr 24, 2025
@github-actions
Copy link
Contributor

Built wire-android-staging-compat-pr-4001.apk is available for download

@github-actions
Copy link
Contributor

Built wire-android-dev-debug-pr-4001.apk is available for download

@sonarqubecloud
Copy link

@MohamadJaara MohamadJaara merged commit a4275ef into develop Apr 24, 2025
11 of 14 checks passed
@MohamadJaara MohamadJaara deleted the fix/the-threshhod-for-ley-material-update branch April 24, 2025 16:36
MohamadJaara added a commit that referenced this pull request May 2, 2025
…nversation key material [WPB-17354] (#4001)

(cherry picked from commit a4275ef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants