feat(Cells): Create cells folder flow (WPB-17272)#4002
Conversation
ohassine
requested review from
a team,
MohamadJaara,
sbakhtiarov,
typfel,
vitorhugods and
yamilmedina
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4002 +/- ##
========================================
Coverage 46.04% 46.04%
========================================
Files 518 519 +1
Lines 18081 18081
Branches 3037 3037
========================================
Hits 8326 8326
Misses 8891 8891
Partials 864 864
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Built wire-android-staging-compat-pr-4002.apk is available for download |
|
Built wire-android-dev-debug-pr-4002.apk is available for download |
|
Built wire-android-staging-compat-pr-4002.apk is available for download |
|
Built wire-android-dev-debug-pr-4002.apk is available for download |
| val state by viewModel.state.collectAsState() | ||
| val sheetState = rememberWireModalSheetState<Unit>() | ||
|
|
||
| FilesNewActionsBottomSheet( |
There was a problem hiding this comment.
Do we have this menu only for conversation files? Maybe we could move it to the "CellScreenContent" so that this bottom sheet will be available also on the all files screen?
There was a problem hiding this comment.
Yes only for conversation files.
| elevation = dimensions().spacing0x | ||
| ) | ||
| }, | ||
| floatingActionButton = { |
There was a problem hiding this comment.
Same as for the menu. We could move this also to "CellScreenContent" to make the FAB available for all file list screens.
There was a problem hiding this comment.
We don't want to show it there, only in conversation files
...res/cells/src/main/java/com/wire/android/feature/cells/ui/createfolder/CreateFolderScreen.kt
Outdated
Show resolved
Hide resolved
|
|
Built wire-android-staging-compat-pr-4002.apk is available for download |
|
Built wire-android-dev-debug-pr-4002.apk is available for download |
3 participants
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Description
Screen_recording_20250424_151220.webm
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.