fix: move mls jobs to start from te UI [WPB-17367]#4003
fix: move mls jobs to start from te UI [WPB-17367]#4003MohamadJaara merged 11 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the foreground MLS job initiation by adding new manager invocations and updating dependency injections.
- Introduces new manager dependencies (MLSMigrationManager, KeyingMaterialsManager, and MLSClientManager) in AppSyncViewModel
- Removes the lowerKeyingMaterialsUpdateThreshold configuration in KaliumConfigsModule
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/main/kotlin/com/wire/android/ui/home/AppSyncViewModel.kt | Added new MLS job managers and invoked them within viewModelScope |
| app/src/main/kotlin/com/wire/android/di/KaliumConfigsModule.kt | Removed lowerKeyingMaterialsUpdateThreshold configuration |
Files not reviewed (1)
- kalium: Language not supported
Comments suppressed due to low confidence (2)
app/src/main/kotlin/com/wire/android/ui/home/AppSyncViewModel.kt:47
- [nitpick] The parameter name 'mLSMigrationManager' appears to violate common camelCase conventions. Consider renaming it to 'mlsMigrationManager' (and similarly update 'mLSClientManager') for consistency.
private val mLSMigrationManager: MLSMigrationManager,
app/src/main/kotlin/com/wire/android/di/KaliumConfigsModule.kt:51
- The removal of 'lowerKeyingMaterialsUpdateThreshold' may have side effects on parts of the system relying on this configuration. Please confirm that this change is intentional and that no dependent functionality is affected.
lowerKeyingMaterialsUpdateThreshold = BuildConfig.PRIVATE_BUILD,
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4003 +/- ##
===========================================
+ Coverage 46.00% 46.02% +0.01%
===========================================
Files 518 518
Lines 18051 18057 +6
Branches 3031 3031
===========================================
+ Hits 8304 8310 +6
Misses 8889 8889
Partials 858 858
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
|
Built wire-android-staging-compat-pr-4003.apk is available for download |
|
Built wire-android-dev-debug-pr-4003.apk is available for download |
(cherry picked from commit 16a5c72)



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
move MLS jobs to kick start only from the foreground
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.