Skip to content

fix: move mls jobs to start from te UI [WPB-17367]#4003

Merged
MohamadJaara merged 11 commits intodevelopfrom
fix/more-MLS-jobs-to-start-from-te-UI
Apr 25, 2025
Merged

fix: move mls jobs to start from te UI [WPB-17367]#4003
MohamadJaara merged 11 commits intodevelopfrom
fix/more-MLS-jobs-to-start-from-te-UI

Conversation

@MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Apr 24, 2025

BugWPB-17367 [Android] unlimited MLS jobs when sync goes live


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

move MLS jobs to kick start only from the foreground

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the foreground MLS job initiation by adding new manager invocations and updating dependency injections.

  • Introduces new manager dependencies (MLSMigrationManager, KeyingMaterialsManager, and MLSClientManager) in AppSyncViewModel
  • Removes the lowerKeyingMaterialsUpdateThreshold configuration in KaliumConfigsModule

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
app/src/main/kotlin/com/wire/android/ui/home/AppSyncViewModel.kt Added new MLS job managers and invoked them within viewModelScope
app/src/main/kotlin/com/wire/android/di/KaliumConfigsModule.kt Removed lowerKeyingMaterialsUpdateThreshold configuration
Files not reviewed (1)
  • kalium: Language not supported
Comments suppressed due to low confidence (2)

app/src/main/kotlin/com/wire/android/ui/home/AppSyncViewModel.kt:47

  • [nitpick] The parameter name 'mLSMigrationManager' appears to violate common camelCase conventions. Consider renaming it to 'mlsMigrationManager' (and similarly update 'mLSClientManager') for consistency.
private val mLSMigrationManager: MLSMigrationManager,

app/src/main/kotlin/com/wire/android/di/KaliumConfigsModule.kt:51

  • The removal of 'lowerKeyingMaterialsUpdateThreshold' may have side effects on parts of the system relying on this configuration. Please confirm that this change is intentional and that no dependent functionality is affected.
lowerKeyingMaterialsUpdateThreshold = BuildConfig.PRIVATE_BUILD,

@MohamadJaara MohamadJaara changed the title fix: more mls jobs to start from te UI fix: move mls jobs to start from te UI Apr 24, 2025
@MohamadJaara MohamadJaara changed the title fix: move mls jobs to start from te UI fix: move mls jobs to start from te UI [WPB-17367] Apr 25, 2025
@MohamadJaara MohamadJaara enabled auto-merge April 25, 2025 10:36
@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.02%. Comparing base (a4275ef) to head (a07820d).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4003      +/-   ##
===========================================
+ Coverage    46.00%   46.02%   +0.01%     
===========================================
  Files          518      518              
  Lines        18051    18057       +6     
  Branches      3031     3031              
===========================================
+ Hits          8304     8310       +6     
  Misses        8889     8889              
  Partials       858      858              
Files with missing lines Coverage Δ
...otlin/com/wire/android/ui/home/AppSyncViewModel.kt 81.25% <100.00%> (+4.32%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4275ef...a07820d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MohamadJaara MohamadJaara disabled auto-merge April 25, 2025 13:44
@MohamadJaara MohamadJaara merged commit 16a5c72 into develop Apr 25, 2025
8 of 10 checks passed
@MohamadJaara MohamadJaara deleted the fix/more-MLS-jobs-to-start-from-te-UI branch April 25, 2025 13:45
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Built wire-android-staging-compat-pr-4003.apk is available for download

@github-actions
Copy link
Contributor

Built wire-android-dev-debug-pr-4003.apk is available for download

MohamadJaara added a commit that referenced this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants