fix(channels): allow team admins to edit guests and self-deleting settings [WPB-17100]#4004
Merged
MohamadJaara merged 2 commits intodevelopfrom Apr 25, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4004 +/- ##
===========================================
+ Coverage 46.02% 46.04% +0.02%
===========================================
Files 518 518
Lines 18057 18081 +24
Branches 3031 3037 +6
===========================================
+ Hits 8310 8326 +16
- Misses 8889 8891 +2
- Partials 858 864 +6
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
MohamadJaara
approved these changes
Apr 25, 2025
|
Garzas
approved these changes
Apr 25, 2025
Contributor
|
Built wire-android-staging-compat-pr-4004.apk is available for download |
Contributor
|
Built wire-android-dev-debug-pr-4004.apk is available for download |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Team admin is unable to change Self-Deleting and Guest settings in channel conversations.
Causes
Solutions
For now... snowball the hack. Change the missing ViewModels to account for channels and team admin.
For the future: centralise all logic in UseCases.
Testing
Test Coverage (Optional)
I did not write tests for code that I want to erase.
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.