Skip to content

fix(channels): allow team admins to edit guests and self-deleting settings [WPB-17100]#4004

Merged
MohamadJaara merged 2 commits intodevelopfrom
fix/team-admins-change-more-channel-settings
Apr 25, 2025
Merged

fix(channels): allow team admins to edit guests and self-deleting settings [WPB-17100]#4004
MohamadJaara merged 2 commits intodevelopfrom
fix/team-admins-change-more-channel-settings

Conversation

@vitorhugods
Copy link
Contributor

@vitorhugods vitorhugods commented Apr 25, 2025

TaskWPB-17100 [Android]Team owner does not receive admin privileges when joining a channel created by a team member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Team admin is unable to change Self-Deleting and Guest settings in channel conversations.

Causes

  • I missed these places when working on previous PRs
  • Logic is spread out in many ViewModels instead of in a few UseCases

Solutions

For now... snowball the hack. Change the missing ViewModels to account for channels and team admin.

For the future: centralise all logic in UseCases.

Testing

Test Coverage (Optional)

I did not write tests for code that I want to erase.


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 69.69697% with 10 lines in your changes missing coverage. Please review.

Project coverage is 46.04%. Comparing base (f07af53) to head (080d79e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...etingmessages/EditSelfDeletingMessagesViewModel.kt 68.18% 4 Missing and 3 partials ⚠️
...etails/editguestaccess/EditGuestAccessViewModel.kt 72.72% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4004      +/-   ##
===========================================
+ Coverage    46.02%   46.04%   +0.02%     
===========================================
  Files          518      518              
  Lines        18057    18081      +24     
  Branches      3031     3037       +6     
===========================================
+ Hits          8310     8326      +16     
- Misses        8889     8891       +2     
- Partials       858      864       +6     
Files with missing lines Coverage Δ
...etails/editguestaccess/EditGuestAccessViewModel.kt 75.91% <72.72%> (-1.02%) ⬇️
...etingmessages/EditSelfDeletingMessagesViewModel.kt 78.68% <68.18%> (-3.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07af53...080d79e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@vitorhugods vitorhugods added this pull request to the merge queue Apr 25, 2025
@MohamadJaara MohamadJaara removed this pull request from the merge queue due to a manual request Apr 25, 2025
@MohamadJaara MohamadJaara merged commit f27e0c2 into develop Apr 25, 2025
12 of 13 checks passed
@MohamadJaara MohamadJaara deleted the fix/team-admins-change-more-channel-settings branch April 25, 2025 16:11
@github-actions
Copy link
Contributor

Built wire-android-staging-compat-pr-4004.apk is available for download

@github-actions
Copy link
Contributor

Built wire-android-dev-debug-pr-4004.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants