Skip to content

fix: run and await app config sync on IO dispatcher [WPB-15730]#4009

Merged
MohamadJaara merged 5 commits intodevelopfrom
fix/start-and-await-sync-job-on-io-dispatcher
May 6, 2025
Merged

fix: run and await app config sync on IO dispatcher [WPB-15730]#4009
MohamadJaara merged 5 commits intodevelopfrom
fix/start-and-await-sync-job-on-io-dispatcher

Conversation

@MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented May 5, 2025

BugWPB-15730 [Android] ANR when opening conversation from notification


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

app sync jobs are joined in the main thread

Solutions

join it on Dispatcher.IO

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.02%. Comparing base (f533b19) to head (3536a08).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4009   +/-   ##
========================================
  Coverage    46.02%   46.02%           
========================================
  Files          520      520           
  Lines        18107    18108    +1     
  Branches      3044     3044           
========================================
+ Hits          8334     8335    +1     
  Misses        8909     8909           
  Partials       864      864           
Files with missing lines Coverage Δ
...otlin/com/wire/android/ui/home/AppSyncViewModel.kt 81.81% <100.00%> (+0.56%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f533b19...3536a08. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MohamadJaara MohamadJaara changed the title fix: run and await app config sync on IO dispatcher fix: run and await app config sync on IO dispatcher [WPB-15730] May 6, 2025
@MohamadJaara MohamadJaara enabled auto-merge May 6, 2025 21:07
…io-dispatcher' into fix/start-and-await-sync-job-on-io-dispatcher
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2025

@MohamadJaara MohamadJaara added this pull request to the merge queue May 6, 2025
Merged via the queue into develop with commit 90d2578 May 6, 2025
12 of 13 checks passed
@MohamadJaara MohamadJaara deleted the fix/start-and-await-sync-job-on-io-dispatcher branch May 6, 2025 21:43
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Built wire-android-staging-compat-pr-4009.apk is available for download

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Built wire-android-dev-debug-pr-4009.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants