Skip to content

chore: simplify new login selector [WPB-15730]#4010

Merged
MohamadJaara merged 4 commits intodevelopfrom
chore/simplify-EnterpriseLogin-selector
May 6, 2025
Merged

chore: simplify new login selector [WPB-15730]#4010
MohamadJaara merged 4 commits intodevelopfrom
chore/simplify-EnterpriseLogin-selector

Conversation

@MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented May 5, 2025

BugWPB-15730 [Android] ANR when opening conversation from notification


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  1. the init is called from the activity on create and it needs a network request
  2. this can cause ANR in very slow internet
  3. init is called event if there is an account logged in and there is no need to select login

Solutions

simplify the flow to use a compile time flag for default server settings and still do http calls for custom servers

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested a review from saleniuk May 6, 2025 12:36
@MohamadJaara MohamadJaara enabled auto-merge May 6, 2025 20:03
@MohamadJaara MohamadJaara disabled auto-merge May 6, 2025 20:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2025

@MohamadJaara MohamadJaara changed the title chore: simplify new login selector chore: simplify new login selector [WPB-15730] May 6, 2025
@MohamadJaara MohamadJaara added this pull request to the merge queue May 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2025
@MohamadJaara MohamadJaara added this pull request to the merge queue May 6, 2025
Merged via the queue into develop with commit 1f58dcd May 6, 2025
12 of 15 checks passed
@MohamadJaara MohamadJaara deleted the chore/simplify-EnterpriseLogin-selector branch May 6, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants