Skip to content

feat: handle federated case for user ids in QR code (WPB-10530)#4012

Merged
yamilmedina merged 9 commits intodevelopfrom
feat/qrcode-federationsupport
May 6, 2025
Merged

feat: handle federated case for user ids in QR code (WPB-10530)#4012
yamilmedina merged 9 commits intodevelopfrom
feat/qrcode-federationsupport

Conversation

@yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented May 5, 2025

StoryWPB-10530 [Android] QR code Profile link Federation - update domain


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Federated case handling for QR code user profile. parsing, sharing, displaying.

Causes (Optional)

Not prioritized before

Solutions

Implement it.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested a review from a team May 5, 2025 16:34
@yamilmedina yamilmedina self-assigned this May 5, 2025
@yamilmedina yamilmedina requested review from Garzas, MohamadJaara, alexandreferris, emmaoke-w and vitorhugods and removed request for a team May 5, 2025 16:34
@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 46.05%. Comparing base (fcb37fb) to head (ed100c7).

Files with missing lines Patch % Lines
...com/wire/android/util/deeplink/UserLinkQRMapper.kt 47.05% 8 Missing and 1 partial ⚠️
...om/wire/android/util/deeplink/DeepLinkProcessor.kt 66.66% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (52.38%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4012   +/-   ##
========================================
  Coverage    46.04%   46.05%           
========================================
  Files          519      520    +1     
  Lines        18081    18096   +15     
  Branches      3037     3039    +2     
========================================
+ Hits          8326     8334    +8     
- Misses        8891     8898    +7     
  Partials       864      864           
Files with missing lines Coverage Δ
...e/android/ui/userprofile/qr/SelfQRCodeViewModel.kt 54.54% <100.00%> (ø)
...om/wire/android/util/deeplink/DeepLinkProcessor.kt 78.03% <66.66%> (+1.16%) ⬆️
...com/wire/android/util/deeplink/UserLinkQRMapper.kt 47.05% <47.05%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcb37fb...ed100c7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Built wire-android-staging-compat-pr-4012.apk is available for download

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Built wire-android-dev-debug-pr-4012.apk is available for download

@pull-request-size pull-request-size bot added size/S and removed size/XS labels May 6, 2025
@yamilmedina yamilmedina requested a review from MohamadJaara May 6, 2025 12:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2025

@yamilmedina yamilmedina enabled auto-merge May 6, 2025 12:34
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Built wire-android-staging-compat-pr-4012.apk is available for download

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Built wire-android-dev-debug-pr-4012.apk is available for download

@yamilmedina yamilmedina dismissed MohamadJaara’s stale review May 6, 2025 12:53

Proposed changes taken and expanded with more coverage for other cases.

@yamilmedina yamilmedina added this pull request to the merge queue May 6, 2025
Merged via the queue into develop with commit e1b7128 May 6, 2025
12 of 13 checks passed
@yamilmedina yamilmedina deleted the feat/qrcode-federationsupport branch May 6, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants