Skip to content

chore: update kotlin to 2.1 [WPB-17116]#4014

Merged
MohamadJaara merged 10 commits intodevelopfrom
chore/upgrade-to-kotlin-2.1
Jun 6, 2025
Merged

chore: update kotlin to 2.1 [WPB-17116]#4014
MohamadJaara merged 10 commits intodevelopfrom
chore/upgrade-to-kotlin-2.1

Conversation

@saleniuk
Copy link
Contributor

@saleniuk saleniuk commented May 7, 2025

TaskWPB-17116 [Android] migrate to kotlin 2.1


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Updated kotlin to 2.1, it required also updating ksp, agp and hilt.
Only crucial changes in this regard were adding compose plugin (it's required in kotlin 2) and using kalium version with updated kotlin as well.

Dependencies (Optional)

Needs releases with:


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk marked this pull request as draft May 7, 2025 08:22
@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.57%. Comparing base (4227eb2) to head (b34f079).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4014      +/-   ##
===========================================
- Coverage    47.73%   47.57%   -0.17%     
===========================================
  Files          491      497       +6     
  Lines        16991    17427     +436     
  Branches      2822     2862      +40     
===========================================
+ Hits          8111     8291     +180     
- Misses        8046     8282     +236     
- Partials       834      854      +20     

see 208 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4227eb2...b34f079. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Built wire-android-staging-compat-pr-4014.apk is available for download

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Built wire-android-dev-debug-pr-4014.apk is available for download

saleniuk added 3 commits June 6, 2025 09:52
…otlin-2.1

# Conflicts:
#	features/cells/build.gradle.kts
#	features/sketch/build.gradle.kts
#	kalium
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2025

@saleniuk saleniuk requested review from a team, Garzas, emmaoke-w, mathias-niboulies, ohassine and sbakhtiarov and removed request for a team June 6, 2025 14:23
@saleniuk saleniuk marked this pull request as ready for review June 6, 2025 14:24
@MohamadJaara MohamadJaara enabled auto-merge June 6, 2025 14:51
@MohamadJaara MohamadJaara disabled auto-merge June 6, 2025 15:04
@MohamadJaara MohamadJaara merged commit 20905fd into develop Jun 6, 2025
12 of 14 checks passed
@MohamadJaara MohamadJaara deleted the chore/upgrade-to-kotlin-2.1 branch June 6, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants