fix: schema validation for attachments - rc (WPB-17546)#4016
Merged
yamilmedina merged 4 commits intorelease/candidatefrom May 12, 2025
Merged
fix: schema validation for attachments - rc (WPB-17546)#4016yamilmedina merged 4 commits intorelease/candidatefrom
yamilmedina merged 4 commits intorelease/candidatefrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #4016 +/- ##
==================================================
Coverage 45.91% 45.92%
==================================================
Files 492 492
Lines 17174 17192 +18
Branches 2862 2864 +2
==================================================
+ Hits 7886 7895 +9
- Misses 8491 8499 +8
- Partials 797 798 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
|
Built wire-android-staging-compat-pr-4016.apk is available for download |
MohamadJaara
approved these changes
May 8, 2025
ohassine
approved these changes
May 12, 2025
|
Contributor
|
Built wire-android-staging-compat-pr-4016.apk is available for download |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Cherry-pick of:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Extra handling needed for the app about sharing attachments, to be more restrict about what can be shared or not
Solutions
Deny the usage of
file://schema. We don't need it in the app, we use as supposed to content resolvers for it.Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.