Conversation
…-attachement-type # Conflicts: # kalium
…-attachement-type # Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/createfolder/CreateFolderScreen.kt
# Conflicts: # app/src/main/kotlin/com/wire/android/di/accountScoped/CellsModule.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/AllFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellListItem.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/download/DownloadFileBottomSheet.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellFileUi.kt # features/cells/src/main/res/values/strings.xml # kalium
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
sbakhtiarov
approved these changes
May 13, 2025
# Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellListItem.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/createfolder/CreateFolderScreenNavArgs.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/dialog/FileActionsBottomSheet.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/dialog/FolderActionsBottomSheet.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellNodeUi.kt # kalium
Contributor
|
@ohassine looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
# Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFilesNavArgs.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt # kalium
yamilmedina
reviewed
May 21, 2025
Contributor
yamilmedina
left a comment
yamilmedina
left a comment
There was a problem hiding this comment.
Looks good, I left one question regarding the excessive unsafe casting we are doing, perhaps the class hierarchy can be modified to avoid it :D
features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
Outdated
Show resolved
Hide resolved
|
Contributor
|
Built wire-android-staging-compat-pr-4019.apk is available for download |
Contributor
|
Built wire-android-dev-debug-pr-4019.apk is available for download |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
PS: This PR contains changes from #4007
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
Attachments (Optional)
Screen_recording_20250512_154755.webm
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.