feat: add activity extension for dynamic screen orientation setup [WPB-21393]#4378
Merged
MohamadJaara merged 2 commits intodevelopfrom Oct 27, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables dynamic screen orientation management for tablets while maintaining portrait-only mode for phones. Instead of relying on manifest-level orientation restrictions, the implementation programmatically sets orientation based on device type using the 600dp threshold that distinguishes tablets from phones.
- Introduces a reusable
setupOrientationForDevice()extension function - Removes static
android:screenOrientation="portrait"declarations from the AndroidManifest - Applies dynamic orientation setup to all main activities (WireActivity, AppLockActivity, and calling activities)
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ActivityExtensions.kt | New extension function that sets orientation based on device screen width (tablets ≥600dp get full sensor rotation, phones get portrait-only) |
| OngoingCallActivity.kt | Calls setupOrientationForDevice() during onCreate to enable dynamic orientation |
| StartingCallActivity.kt | Calls setupOrientationForDevice() during onCreate to enable dynamic orientation |
| CallActivity.kt | Minor import reordering (no functional change) |
| WireActivity.kt | Calls setupOrientationForDevice() during onCreate to enable dynamic orientation |
| AppLockActivity.kt | Calls setupOrientationForDevice() during onCreate to enable dynamic orientation |
| AndroidManifest.xml | Removes hardcoded portrait orientation restrictions from activity declarations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sbakhtiarov
approved these changes
Oct 27, 2025
|
vitorhugods
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Instead of relying on Google to enforce it, enable it for all tablets with all Android versions in code
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.