Skip to content

Comments

feat: add activity extension for dynamic screen orientation setup [WPB-21393]#4378

Merged
MohamadJaara merged 2 commits intodevelopfrom
mo/feat/setup-activity-orintaion-programmatically
Oct 27, 2025
Merged

feat: add activity extension for dynamic screen orientation setup [WPB-21393]#4378
MohamadJaara merged 2 commits intodevelopfrom
mo/feat/setup-activity-orintaion-programmatically

Conversation

@MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Oct 27, 2025

TaskWPB-21393 [Android] Enable landscape mode for all tablets


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Instead of relying on Google to enforce it, enable it for all tablets with all Android versions in code

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables dynamic screen orientation management for tablets while maintaining portrait-only mode for phones. Instead of relying on manifest-level orientation restrictions, the implementation programmatically sets orientation based on device type using the 600dp threshold that distinguishes tablets from phones.

  • Introduces a reusable setupOrientationForDevice() extension function
  • Removes static android:screenOrientation="portrait" declarations from the AndroidManifest
  • Applies dynamic orientation setup to all main activities (WireActivity, AppLockActivity, and calling activities)

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ActivityExtensions.kt New extension function that sets orientation based on device screen width (tablets ≥600dp get full sensor rotation, phones get portrait-only)
OngoingCallActivity.kt Calls setupOrientationForDevice() during onCreate to enable dynamic orientation
StartingCallActivity.kt Calls setupOrientationForDevice() during onCreate to enable dynamic orientation
CallActivity.kt Minor import reordering (no functional change)
WireActivity.kt Calls setupOrientationForDevice() during onCreate to enable dynamic orientation
AppLockActivity.kt Calls setupOrientationForDevice() during onCreate to enable dynamic orientation
AndroidManifest.xml Removes hardcoded portrait orientation restrictions from activity declarations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

@MohamadJaara MohamadJaara changed the title feat: add activity extension for dynamic screen orientation setup feat: add activity extension for dynamic screen orientation setup [WPB-21393] Oct 27, 2025
@MohamadJaara MohamadJaara added this pull request to the merge queue Oct 27, 2025
Merged via the queue into develop with commit 1f1db40 Oct 27, 2025
14 of 16 checks passed
@MohamadJaara MohamadJaara deleted the mo/feat/setup-activity-orintaion-programmatically branch October 27, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants