Skip to content

Comments

fix: crash when selecting color for brand new users [WPB-21464]#4388

Merged
MohamadJaara merged 2 commits intodevelopfrom
mo/fix/crash-when-selecting-color-without-having-once-before
Oct 30, 2025
Merged

fix: crash when selecting color for brand new users [WPB-21464]#4388
MohamadJaara merged 2 commits intodevelopfrom
mo/fix/crash-when-selecting-color-without-having-once-before

Conversation

@MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Oct 30, 2025

BugWPB-21464 [Android] fix crash when changing accdent color for users with no accent color


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

crash when selecting color for brand new users

Solutions

change design to handle unknow accent

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the title fix: crash when selecting color for brand new users fix: crash when selecting color for brand new users [WPB-21464] Oct 30, 2025
@sonarqubecloud
Copy link

@MohamadJaara MohamadJaara merged commit 9592b62 into develop Oct 30, 2025
16 of 18 checks passed
@MohamadJaara MohamadJaara deleted the mo/fix/crash-when-selecting-color-without-having-once-before branch October 30, 2025 13:13
MohamadJaara added a commit that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants