feat(cells): Download file version (WPB-21661) #4469

ohassine · 2025-12-09T08:51:39Z

WPB-21661 [Android] Implement versioning

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Download file version

Screen_recording_20251209_094921.webm

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

# Conflicts: # app/src/main/kotlin/com/wire/android/di/accountScoped/CellsModule.kt # features/cells/src/main/res/values/strings.xml # kalium

…node-versions # Conflicts: # kalium

…node-versions # Conflicts: # features/cells/src/main/res/values/strings.xml

…node-versions # Conflicts: # kalium

…node-versions # Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/res/values/strings.xml

…node-versions

# Conflicts: # app/src/main/kotlin/com/wire/android/di/accountScoped/CellsModule.kt # core/ui-common/src/main/res/values/strings.xml # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/res/values/strings.xml # kalium

…node-versions # Conflicts: # app/src/main/kotlin/com/wire/android/di/accountScoped/CellsModule.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/res/values/strings.xml # features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/publiclink/PublicLinkViewModelTest.kt # kalium

.../cells/src/main/java/com/wire/android/feature/cells/ui/versioning/VersionHistoryViewModel.kt

yamilmedina

Looks good! Left a couple of suggestions/questions 🚀

app/src/main/kotlin/com/wire/android/ui/WireActivity.kt

.../cells/src/main/java/com/wire/android/feature/cells/ui/versioning/VersionHistoryViewModel.kt

github-actions · 2025-12-17T11:50:11Z

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
da23023e4b8c533b4a7751660b2344cba0d8158b	fc1a4496cf645e41e8b98cd23833cbbeb87a839a

Is this intentional?

github-actions · 2025-12-17T14:49:32Z

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
da23023e4b8c533b4a7751660b2344cba0d8158b	fc1a4496cf645e41e8b98cd23833cbbeb87a839a

Is this intentional?

github-actions · 2025-12-17T15:21:32Z

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
da23023e4b8c533b4a7751660b2344cba0d8158b	fc1a4496cf645e41e8b98cd23833cbbeb87a839a

Is this intentional?

github-actions · 2025-12-17T16:47:48Z

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
da23023e4b8c533b4a7751660b2344cba0d8158b	fc1a4496cf645e41e8b98cd23833cbbeb87a839a

Is this intentional?

# Conflicts: # kalium

sonarqubecloud · 2025-12-18T14:07:42Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ohassine added 30 commits November 26, 2025 10:05

feat: version history screen

4706eca

feat: cleanup

a1bc8ef

feat: cleanup

857cdf0

Merge remote-tracking branch 'origin/develop' into fetch-node-versions

4eefc69

# Conflicts: # app/src/main/kotlin/com/wire/android/di/accountScoped/CellsModule.kt # features/cells/src/main/res/values/strings.xml # kalium

feat: fetch and display node versions

6c182d8

feat: fetch and display node versions

ce46c89

feat: unit test

f4dd342

feat: kalium

92c5b49

Merge remote-tracking branch 'origin/develop' into fetch-and-display-…

ea05b7a

…node-versions # Conflicts: # kalium

Merge remote-tracking branch 'origin/develop' into fetch-and-display-…

c24e792

…node-versions # Conflicts: # features/cells/src/main/res/values/strings.xml

Merge remote-tracking branch 'origin/develop' into fetch-and-display-…

6883656

…node-versions # Conflicts: # kalium

feat: add feature flag

ef20c4c

feat: add a TODO

9e3644e

Merge remote-tracking branch 'origin/develop' into fetch-and-display-…

794168d

…node-versions # Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/res/values/strings.xml

feat: cleanup

db5d4bf

feat: cleanup

fec23eb

feat: cleanup

0e97c39

feat: detekt

3471ce3

feat: kalium reference

03184d8

Merge remote-tracking branch 'origin/develop' into fetch-and-display-…

6913bc2

…node-versions

feat: cleanup

2752835

feat: restore node version

357148b

feat: cleanup

303ec8f

feat: add file name to top bar

5181f83

feat: pull to refresh

3a07db6

feat: dismissOnClickOutside dialog

4f7c981

feat: download node version

189915c

feat: address comments

41dbd05

sbakhtiarov requested changes Dec 9, 2025

View reviewed changes

feat: cleanup

832d596

ohassine requested a review from sbakhtiarov December 9, 2025 13:55

sbakhtiarov approved these changes Dec 9, 2025

View reviewed changes

ohassine requested a review from yamilmedina December 9, 2025 15:47

ohassine mentioned this pull request Dec 9, 2025

feat: cover VersionHistoryViewModel with unit test (WPB-21661) #4473

Merged

8 tasks

yamilmedina reviewed Dec 15, 2025

View reviewed changes

app/src/main/kotlin/com/wire/android/ui/WireActivity.kt Outdated Show resolved Hide resolved

.../cells/src/main/java/com/wire/android/feature/cells/ui/versioning/VersionHistoryViewModel.kt Show resolved Hide resolved

fix: resolve conflicts

abb9e9c

pull-request-size bot added size/S and removed size/L labels Dec 17, 2025

ohassine requested a review from yamilmedina December 17, 2025 12:09

yamilmedina approved these changes Dec 17, 2025

View reviewed changes

Merge branch 'develop' into download-version

0ed6f22

fix: cleanup

2e45dd9

fix: test

fba0da2

pull-request-size bot added size/M and removed size/S labels Dec 17, 2025

ohassine added 2 commits December 18, 2025 13:01

Merge remote-tracking branch 'origin/develop' into download-version

bc7ccea

# Conflicts: # kalium

fix: support android 8–9

0b35980

ohassine enabled auto-merge December 18, 2025 12:47

fix: lint

d555ba0

ohassine added this pull request to the merge queue Dec 18, 2025

Merged via the queue into develop with commit 2595d06 Dec 18, 2025
14 of 15 checks passed

ohassine deleted the download-version branch December 18, 2025 14:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(cells): Download file version (WPB-21661) #4469

feat(cells): Download file version (WPB-21661) #4469

Uh oh!

ohassine commented Dec 9, 2025 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yamilmedina left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

sonarqubecloud bot commented Dec 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(cells): Download file version (WPB-21661) #4469

feat(cells): Download file version (WPB-21661) #4469

Uh oh!

Conversation

ohassine commented Dec 9, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yamilmedina left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

sonarqubecloud bot commented Dec 18, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ohassine commented Dec 9, 2025 •

edited by github-actions bot

Loading

yamilmedina left a comment •

edited

Loading