Skip to content

Conversation

@ohassine
Copy link
Member

@ohassine ohassine commented Dec 12, 2025

TaskWPB-21649 [Android] Search files in Conversation


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Screen_recording_20251212_155423.webm

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…nversation

# Conflicts:
#	features/cells/src/main/res/values/strings.xml
#	kalium
@github-actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
da23023e4b8c533b4a7751660b2344cba0d8158b 479d039ef9211548cdd4076f7cdbd9f0248059e7

Is this intentional?

@ohassine ohassine enabled auto-merge December 17, 2025 10:57
@github-actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
da23023e4b8c533b4a7751660b2344cba0d8158b 479d039ef9211548cdd4076f7cdbd9f0248059e7

Is this intentional?

@github-actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
da23023e4b8c533b4a7751660b2344cba0d8158b 479d039ef9211548cdd4076f7cdbd9f0248059e7

Is this intentional?

@github-actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
da23023e4b8c533b4a7751660b2344cba0d8158b 479d039ef9211548cdd4076f7cdbd9f0248059e7

Is this intentional?

@github-actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
da23023e4b8c533b4a7751660b2344cba0d8158b 479d039ef9211548cdd4076f7cdbd9f0248059e7

Is this intentional?

@github-actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
da23023e4b8c533b4a7751660b2344cba0d8158b a56c66b26813c645ba9f194dfab25280b7804f75

Is this intentional?

…nversation

# Conflicts:
#	core/ui-common/src/main/res/values-de/strings.xml
#	core/ui-common/src/main/res/values-hu/strings.xml
#	core/ui-common/src/main/res/values-it/strings.xml
#	core/ui-common/src/main/res/values-pt/strings.xml
#	core/ui-common/src/main/res/values-ru/strings.xml
#	core/ui-common/src/main/res/values-si/strings.xml
#	features/cells/src/main/res/values/strings.xml
@sonarqubecloud
Copy link

@ohassine ohassine added this pull request to the merge queue Dec 18, 2025
Merged via the queue into develop with commit 8162b50 Dec 18, 2025
13 of 14 checks passed
@ohassine ohassine deleted the search-in-cells-conversation branch December 18, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants