Skip to content

Conversation

@yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 17, 2025

BugWPB-22180 [Android] "Message could not be decrypted" from federated connection


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Follow up on #4484

  • This PR is focused on triggering the process on app start, and mark as completed.
  • Change the structure of the config to be: {"domain": ["some hex string key"]}.
  • Pass to Kalium using current Configs, so it can be triggered automatically with the data to be targeted.

IMPORTANT!
Update the env vars in the gh repository

Issues

Conversations break if the removal key is rotated in the Backend

Solutions

Detect MLS conversations with the faulty key and belonging to the target domain, if there is match, trigger a MLS reset flow.

Depends on

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.54%. Comparing base (b57fde8) to head (637177e).

Files with missing lines Patch % Lines
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 0.00% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4487   +/-   ##
=======================================
  Coverage   47.54%   47.54%           
=======================================
  Files         536      536           
  Lines       18054    18054           
  Branches     3058     3058           
=======================================
  Hits         8584     8584           
  Misses       8545     8545           
  Partials      925      925           
Files with missing lines Coverage Δ
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 49.30% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57fde8...637177e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@MohamadJaara MohamadJaara merged commit 9dad777 into main Dec 22, 2025
16 of 17 checks passed
@MohamadJaara MohamadJaara deleted the yamil/feat/trigger-faultykey-recover-onlaunch branch December 22, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants