Skip to content

Conversation

@yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 7, 2026

BugWPB-22609 [Android] Setting up Wire page loads endlessly after Clear Data logout and immediate re-login (SSO)


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Observing the user accounts and triggering sync after certain login scenarios does not work.

Causes (Optional)

Introduced while using explicitApi() and hiding repositories from being accessed.

Solutions

Consume an already created raw sessions flow use case to be consumed by the app, instead of using a differenent source.

Dependencies (Optional)

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Login using sso flow, and the app should not be stuck on welcome screen.

Attachments

Screen_recording_20260107_125246.webm

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.69%. Comparing base (82bbdb9) to head (4e7e5cf).

Files with missing lines Patch % Lines
...ire/android/util/lifecycle/SyncLifecycleManager.kt 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4508      +/-   ##
===========================================
- Coverage    48.70%   48.69%   -0.02%     
===========================================
  Files          563      563              
  Lines        19503    19503              
  Branches      3252     3254       +2     
===========================================
- Hits          9499     9497       -2     
- Misses        9007     9008       +1     
- Partials       997      998       +1     
Files with missing lines Coverage Δ
...ire/android/util/lifecycle/SyncLifecycleManager.kt 90.90% <88.23%> (-6.07%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82bbdb9...4e7e5cf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ohassine ohassine added this pull request to the merge queue Jan 7, 2026
Merged via the queue into develop with commit 38ce6f5 Jan 7, 2026
22 of 23 checks passed
@ohassine ohassine deleted the yamil/fix/broken-sso-login-flow branch January 7, 2026 12:37
ohassine pushed a commit that referenced this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants