Skip to content

fix(nomad): hide session expired modal after another successful login (WPB-24304)#4677

Open
ohassine wants to merge 2 commits intodevelopfrom
hide-session-Expired-modal-after-another-successful-login
Open

fix(nomad): hide session expired modal after another successful login (WPB-24304)#4677
ohassine wants to merge 2 commits intodevelopfrom
hide-session-Expired-modal-after-another-successful-login

Conversation

@ohassine
Copy link
Member

@ohassine ohassine commented Mar 25, 2026

https://wearezeta.atlassian.net/browse/WPB-24304


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Session expired modal stays visible even after another successful login on device

Causes (Optional)

We don't hide the the dialog when there is valid accountsInfo

Solutions

Observe account info and update dialog state

How to Test

  • Login on device A via intent
  • Login on device B via intent with same account, and do not dismiss "expired session" dialog on device A
  • Login again on device A with intent with same account

Actual:
"expired session" dialog stays visible, and once you click on it you will be navigated to login screen
Expected:
"expired session" dialog is dismissed after login

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title fix: hide session expired modal after another successful login (WPB-24304) fix(nomad): hide session expired modal after another successful login (WPB-24304) Mar 26, 2026
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants