Skip to content

Conversation

@findms
Copy link
Contributor

@findms findms commented Nov 24, 2025

TaskWPB-20997 [iOS/QA] Explore Tags in XCTest


Summary

Briefly describe about this PR changes.

  • Added configuration in the env variable to run critical tests if test name has word critical
    Configuration for critical test run added so basically it check if test name has critical(ignore casing) then running critical testplan will run all the tests which has critical word, if running normal configuration(as before) it will run all tests.

Testing

Describe how to verify the changes locally. Attach screenshots of local execution if relevant.

tests name updated with critical like this
image

On running test using command bundle exec fastlane run_uitests configuration:UITest-critical , only test with critical word will run not others.

Additional Information

any more info, add here.

How to run?
To run tests marked with tags critical here is the command:
bundle exec fastlane run_uitests configuration:UITest-critical

if configuration is not being passed, it will run all tests as regression.
bundle exec fastlane run_uitests

@findms findms changed the title Chore: Adding tags to the UITests - WPB-20997 Chore: adding tags to the UITests - WPB-20997 Nov 24, 2025
@findms findms changed the title Chore: adding tags to the UITests - WPB-20997 chore: adding tags to the UITests - WPB-20997 Nov 24, 2025
@findms findms marked this pull request as ready for review December 29, 2025 22:38
@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

Test Results

1 872 tests   1 845 ✅  2m 3s ⏱️
  301 suites     27 💤
    1 files        0 ❌

Results for commit 125ef7a.

♻️ This comment has been updated with latest results.

@findms findms requested review from johnxnguyen and netbe January 5, 2026 08:24
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting way to use kind of "tags" in XCTest as it would be in SwiftTesting. For our usecase, I wonder if it's worth it to have this rather to rely on a specific testplan that would contain the critical tests: the same way we have security tests.

what do you think @johnxnguyen ?

@johnxnguyen
Copy link
Collaborator

interesting way to use kind of "tags" in XCTest as it would be in SwiftTesting. For our usecase, I wonder if it's worth it to have this rather to rely on a specific testplan that would contain the critical tests: the same way we have security tests.

what do you think @johnxnguyen ?

@findms @netbe

It's a shame that you can't add tags to XCTest cases like can for Swift Testing as that would be the preferred approach. For me, the better solution for XCTests is to have specific test plans (note that a single test can be in multiple test plans) as this will make it easier for people to read and it aligns with what we currently do already. I'd be cautious about adding additional variations for organizing and running tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants