-
Notifications
You must be signed in to change notification settings - Fork 24
chore: adding tags to the UITests - WPB-20997 #3933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Test Results1 872 tests 1 845 ✅ 2m 3s ⏱️ Results for commit 125ef7a. ♻️ This comment has been updated with latest results. |
netbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting way to use kind of "tags" in XCTest as it would be in SwiftTesting. For our usecase, I wonder if it's worth it to have this rather to rely on a specific testplan that would contain the critical tests: the same way we have security tests.
what do you think @johnxnguyen ?
It's a shame that you can't add tags to XCTest cases like can for Swift Testing as that would be the preferred approach. For me, the better solution for XCTests is to have specific test plans (note that a single test can be in multiple test plans) as this will make it easier for people to read and it aligns with what we currently do already. I'd be cautious about adding additional variations for organizing and running tests. |
Summary
Briefly describe about this PR changes.
Configuration for critical test run added so basically it check if test name has critical(ignore casing) then running critical testplan will run all the tests which has critical word, if running normal configuration(as before) it will run all tests.
Testing
Describe how to verify the changes locally. Attach screenshots of local execution if relevant.
tests name updated with critical like this

On running test using command
bundle exec fastlane run_uitests configuration:UITest-critical, only test with critical word will run not others.Additional Information
any more info, add here.
How to run?
To run tests marked with tags critical here is the command:
bundle exec fastlane run_uitests configuration:UITest-criticalif configuration is not being passed, it will run all tests as regression.
bundle exec fastlane run_uitests