fix: update reaction background color with profile color - WPB-21050#4253
Conversation
SyamalaHari
requested review from
netbe and
samwyndham
and removed request for
netbe
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit cccbbee. ♻️ This comment has been updated with latest results. Summary: workflow run #21753406464 |
samwyndham
left a comment
samwyndham
left a comment
There was a problem hiding this comment.
Nice work. I also tested on my device and behavior looks good.
netbe
left a comment
netbe
left a comment
There was a problem hiding this comment.
left some comments before approving
| self.message = message | ||
| self.onToggle = onToggle | ||
| self.accentColor = message?.senderUser?.accentColor ?? .blue | ||
| self.accentColor = ZMUserSession.shared()?.selfUser.accentColor |
There was a problem hiding this comment.
question: is it possible to pass the accentColor instead of using the shared instance?
There was a problem hiding this comment.
We don't have accentColor. We need to pass userSession from top-level and get accentcolor
| } | ||
|
|
||
| private func updateAppearance() { | ||
| accentColor = ZMUserSession.shared()?.selfUser.accentColor |
There was a problem hiding this comment.
?question: can't you cast the userSession instead ?
There was a problem hiding this comment.
MessageReactioncell doesn't have user session, we need to pass from top level. I will have a look
…urs as per the latest dark theme colours"
|
3 participants
Issue
Reaction background colour remains blue doesn't change with profile color
Now the background color is setup as profilecolor.withAlphaComponent(0.5) of self user
Background colour will update immediately when user profile colour is changed from web client by using AccentColorChangeHandler
Testing
Add a reaction to a message
Observe background of the reaction
Update the profile colour and observe reaction colours
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: