fix: files percent encoding - WPB-23207 🍒 🍒#4256
Merged
WilhelmOks merged 1 commit intodevelopfrom Feb 4, 2026
Merged
Conversation
Co-authored-by: Wilhelm Oks <50032051+WilhelmOks@users.noreply.github.com>
WilhelmOks
approved these changes
Feb 4, 2026
Collaborator
|
auto-approve trigger |
zenkins
approved these changes
Feb 4, 2026
Collaborator
zenkins
left a comment
zenkins
left a comment
There was a problem hiding this comment.
✅ Auto-approved cherry-pick PR 🍒.
Contributor
Author
Test Results255 tests 255 ✅ 29s ⏱️ Results for commit d415b47. Summary: workflow run #21664297135 |
WilhelmOks
deleted the
fix/WPB-23207-files-percent-encoding-cherry-pick-cherry-pick
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
Issue
Renaming files was adding percent encoding like
%20for spaceThis was because the file path was wrapped into a URL and then was converted to a String using
.absoluteString.I fixed that by calling
.removingPercentEncodingbefore that string is used.The percent encoding isn't visible in iOS but you can check it in the web app.
I also tested creating folders, moving folders and uploading drafts. None of those cases have that issue in 4.14, so no code needs to be changed there.
We should also test if creating new files for Collabora (templates) is affected, but that feature is not in 4.14.
Testing
Creating, moving and renaming files and folders should not cause the file names to have percent encodings. Percent encodings are only visible in the web app (and probably Android)
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: