Skip to content

fix: occasional deadlock configuring AVCaptureSession - WPB-23237 #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samwyndham merged 2 commits into from
Feb 5, 2026
+6 −1
Merged

fix: occasional deadlock configuring AVCaptureSession - WPB-23237 #4259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e932eac
Fix occasional crash configuring `AVCaptureSession`
samwyndham Feb 3, 2026
6b6699b
Merge branch 'release/cycle-4.15' into fix/crash-starting-camera-prev…
samwyndham Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion wire-ios/Wire-iOS/Sources/UserInterface/Camera/CameraController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,13 @@ final class CameraController {
init?(camera: SettingsCamera) {
guard !UIDevice.isSimulator else { return nil }
self.currentCamera = camera
setupSession()
self.previewLayer = AVCaptureVideoPreviewLayer(session: session)

// `setupSession()` performs session configuration on a dedicated serial queue. This needs to happen after the
// `previewLayer` is created to avoid simultaneous session configuration across different threads as
// `AVCaptureVideoPreviewLayer` appears to configure the session internally on the main thread during init.
// Configuring the `AVCaptureSession` from multiple threads can lead to a deadlock.
setupSession()
}

// MARK: - Session Management
Expand Down
Loading