fix: ci failure tests - WPB-23003#4261
Conversation
Test Results2 133 tests 2 105 ✅ 3m 17s ⏱️ Results for commit b31c986. ♻️ This comment has been updated with latest results. Summary: workflow run #21751336619 |
netbe
left a comment
netbe
left a comment
There was a problem hiding this comment.
the changes are ok, but please look at the suggestions, this could hide bigger issues
| else { | ||
| XCTFail("Passcode SecureTextField did not appear") | ||
| throw XCTSkip("Passcode field not available") | ||
| // Sometimes the splashscreen stays visible for unexpectedly long. |
There was a problem hiding this comment.
suggestion: it's good as a workaround, but to me we should investigate what's going on:
- when does this happen?
- and extract the app logs when this happens
it could hide a bigger issue
There was a problem hiding this comment.
Completely agree to avoid any workarounds but currently the 2 tests flaky behaviour is weird on Ci not on local:
- For the test where it fails to open user profile - it simply closes the app when app is in sync doesn;t wait for the next page element which is ~15 seconds
openinguserprofile.mp4
- Foe the seconds issue: with app lock with passcode - coming from background to foreground, sometime it takes loner on splashscreen so increase the time out and also observed that, without performing tap() if we directly typeText() it works as fallback in case of secureText is not able to locate.
There was a problem hiding this comment.
Found it.. the tap is actually being performed not on the exact button.
There was a problem hiding this comment.
Locally I fail to replicate. This same function is being used few places but all works fine except one test.
|
|
||
| if userAccountButton.waitAndTap(timeout: 5.0) { | ||
| return try UserProfilePage() | ||
| } |
There was a problem hiding this comment.
suggestion: it would be interesting to know why it's not tappable, because the issue could be somewhere else
There was a problem hiding this comment.
removed this fallback as not needed.
David-Henner
left a comment
David-Henner
left a comment
There was a problem hiding this comment.
Maybe there's another issue somewhere ? I don't feel comfortable working around it unless we're sure there's not something broken
hey @David-Henner I have revert the fallbacks, but found a potential reason when app is in sync mode fails to perform tap(). |
|
3 participants
Issue
Flaky tests observed in v4.15.
Changes:
Testing
Describe how to test.
ran locally - works fine
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: