fix: SSO reconnection fails - WPB-23076#4268
Merged
David-Henner merged 8 commits intorelease/cycle-4.15from Feb 5, 2026
Merged
fix: SSO reconnection fails - WPB-23076#4268David-Henner merged 8 commits intorelease/cycle-4.15from
David-Henner merged 8 commits intorelease/cycle-4.15from
Conversation
Contributor
Test Results1 973 tests 1 946 ✅ 2m 26s ⏱️ Results for commit 007705d. ♻️ This comment has been updated with latest results. Summary: workflow run #21718317152 |
samwyndham
approved these changes
Feb 5, 2026
Contributor
samwyndham
left a comment
There was a problem hiding this comment.
Nice work! Left one optional and opinionated comment.
WireAuthentication/Tests/WireAuthenticationLogicTests/ValidateSSOCodeUseCaseTests.swift
Outdated
Show resolved
Hide resolved
|
zenkins
pushed a commit
that referenced
this pull request
Feb 5, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue
Re-authentication via SSO fails
Cause
In
ReloginViaSSOViewModelwe validate the sso code by trying to convert the user input string to aUUID. However, the format of sso code is as such:wire-5e336058-05f8-4896-bcf8-cb9952bcdf76. We havewire-prefix that needs to be stripped before creating the UUID. The extra characters make the validation fail because it cannot convert it to UUID directly.Solution
Reuse the
SSOCodeValidatorfrom the login flow in order to validate the SSO codeTesting
Requirement: Have a team with SSO enabled
Checklist
[WPB-XXX].