Skip to content

fix: SSO reconnection fails - WPB-23076#4268

Merged
David-Henner merged 8 commits intorelease/cycle-4.15from
fix/sso-reconnection-fails-WPB-23076
Feb 5, 2026
Merged

fix: SSO reconnection fails - WPB-23076#4268
David-Henner merged 8 commits intorelease/cycle-4.15from
fix/sso-reconnection-fails-WPB-23076

Conversation

@David-Henner
Copy link
Contributor

@David-Henner David-Henner commented Feb 4, 2026

BugWPB-23076 [iOS/Desktop] : Wire SSO Reconnection Fails

Issue

Re-authentication via SSO fails

Cause

In ReloginViaSSOViewModel we validate the sso code by trying to convert the user input string to a UUID. However, the format of sso code is as such: wire-5e336058-05f8-4896-bcf8-cb9952bcdf76. We have wire- prefix that needs to be stripped before creating the UUID. The extra characters make the validation fail because it cannot convert it to UUID directly.

Solution

Reuse the SSOCodeValidator from the login flow in order to validate the SSO code

Testing

Requirement: Have a team with SSO enabled

  1. Log in via SSO
  2. Trigger access token failure
  3. Reauthenticate via SSO

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@David-Henner David-Henner marked this pull request as ready for review February 5, 2026 11:57
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Test Results

1 973 tests   1 946 ✅  2m 26s ⏱️
  323 suites     27 💤
    2 files        0 ❌

Results for commit 007705d.

♻️ This comment has been updated with latest results.

Summary: workflow run #21718317152
Allure report (download zip): html-report-27584-fix_sso-reconnection-fails-WPB-23076

@David-Henner David-Henner requested review from a team, netbe and samwyndham February 5, 2026 13:45
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left one optional and opinionated comment.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;)

@David-Henner David-Henner enabled auto-merge (squash) February 5, 2026 14:43
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@David-Henner David-Henner merged commit 8a7c922 into release/cycle-4.15 Feb 5, 2026
12 checks passed
@David-Henner David-Henner deleted the fix/sso-reconnection-fails-WPB-23076 branch February 5, 2026 16:22
zenkins pushed a commit that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants