Skip to content

feat: Respond to QR code backend feature flag and turn QR code feature on /…#4270

Open
JaCaLlaSchwarz wants to merge 1 commit intodevelopfrom
feat/toggle-qr-code-by-flag_WPB22095
Open

feat: Respond to QR code backend feature flag and turn QR code feature on /…#4270
JaCaLlaSchwarz wants to merge 1 commit intodevelopfrom
feat/toggle-qr-code-by-flag_WPB22095

Conversation

@JaCaLlaSchwarz
Copy link
Collaborator

@JaCaLlaSchwarz JaCaLlaSchwarz commented Feb 5, 2026

BugWPB-22095 [iOS] Respond to QR code backend feature flag and turn QR code feature on / off according to flag setting

Issue

Respond to QR code backend feature flag and turn QR code feature on / off according to flag setting

Testing

Case: Flag disabled (default) / (attached video: WhenDisabled_WPB22095)

  1. Select profile and check that QR button is presented. ('3)
  2. Open with Safare user deeplink and check that user profile screen is presented ('25)
WhenDisabled_WPB22095

Case: Flag enabled / (attached video: WhenEnabled_WPB22095)

  1. Select profile and check that QR button is NOT presented. ('3)
  2. Open with Safare user deeplink and check that on conversationo is presented an alert ('10)
WhenEnabled_WPB22095

Evidences
Disabled Enabled
BeforeFix_WPB20582 AfterFix_WPB20582
BeforeFix_WPB20582 AfterFix_WPB20582

Testing

... ongoing

Manual test

... ongoing


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@JaCaLlaSchwarz JaCaLlaSchwarz self-assigned this Feb 5, 2026
@JaCaLlaSchwarz JaCaLlaSchwarz changed the title Respond to QR code backend feature flag and turn QR code feature on /… feat: Respond to QR code backend feature flag and turn QR code feature on /… Feb 5, 2026
@JaCaLlaSchwarz JaCaLlaSchwarz marked this pull request as ready for review February 5, 2026 15:10
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Test Results

    7 files  1 003 suites   8m 22s ⏱️
7 459 tests 7 432 ✅ 27 💤 0 ❌
7 471 runs  7 444 ✅ 27 💤 0 ❌

Results for commit 1d67a1c.

♻️ This comment has been updated with latest results.

Summary: workflow run #21750301111
Allure report (download zip): html-report-27628-feat_toggle-qr-code-by-flag_WPB22095

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 5, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

testOpen_CollectFlushesOnTimeout() from WireNetworkTests.PushChannelV2Tests (Datadog) (Fix with Cursor)
PushChannelV2Tests.swift:438: failed - wrong number of batches, got 4, expected 3

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 989ae5d | Docs | Was this helpful? Give us feedback!

@JaCaLlaSchwarz JaCaLlaSchwarz force-pushed the feat/toggle-qr-code-by-flag_WPB22095 branch from 431ebb8 to 2972686 Compare February 5, 2026 17:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

@JaCaLlaSchwarz JaCaLlaSchwarz force-pushed the feat/toggle-qr-code-by-flag_WPB22095 branch 3 times, most recently from 608d185 to 4e93c81 Compare February 6, 2026 12:55
… off according to flag setting

Removed forced unwrapped.
qrButton.isHidden initialized with !user.isSelfUser

Fix SonarCloud issues.

SwiftFormat issue
@JaCaLlaSchwarz JaCaLlaSchwarz force-pushed the feat/toggle-qr-code-by-flag_WPB22095 branch from 4e93c81 to 75a2c4b Compare February 6, 2026 13:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant