feat: Respond to QR code backend feature flag and turn QR code feature on /…#4270
Open
JaCaLlaSchwarz wants to merge 1 commit intodevelopfrom
Open
feat: Respond to QR code backend feature flag and turn QR code feature on /…#4270JaCaLlaSchwarz wants to merge 1 commit intodevelopfrom
JaCaLlaSchwarz wants to merge 1 commit intodevelopfrom
Conversation
Contributor
Test Results 7 files 1 003 suites 8m 22s ⏱️ Results for commit 1d67a1c. ♻️ This comment has been updated with latest results. Summary: workflow run #21750301111 |
|
431ebb8 to
2972686
Compare
|
608d185 to
4e93c81
Compare
… off according to flag setting Removed forced unwrapped. qrButton.isHidden initialized with !user.isSelfUser Fix SonarCloud issues. SwiftFormat issue
4e93c81 to
75a2c4b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue
Respond to QR code backend feature flag and turn QR code feature on / off according to flag setting
Testing
Case: Flag disabled (default) / (attached video: WhenDisabled_WPB22095)
Case: Flag enabled / (attached video: WhenEnabled_WPB22095)
Evidences
Disabled
Enabled




Testing
... ongoing
Manual test
... ongoing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: