fix: Mentions in chat bubbles should not be underlined - WPB-20367#4329
Open
SyamalaHari wants to merge 2 commits intodevelopfrom
Open
fix: Mentions in chat bubbles should not be underlined - WPB-20367#4329SyamalaHari wants to merge 2 commits intodevelopfrom
SyamalaHari wants to merge 2 commits intodevelopfrom
Conversation
Contributor
Test Results1 868 tests 1 841 ✅ 2m 14s ⏱️ Results for commit c2ed28a. ♻️ This comment has been updated with latest results. Summary: workflow run #22155372684 |
|
JaCaLlaSchwarz
approved these changes
Feb 19, 2026
| } | ||
| // Check if this link range overlaps with any mention. | ||
| // If it does, the mention's styling (no underline) should take precedence. | ||
| let isOverlappingMention = mentionRanges.contains { NSIntersectionRange(linkRange, $0).length > 0 } |
Collaborator
There was a problem hiding this comment.
Is really needed this comment? Implementation is readable.
| in: NSRange(location: 0, length: mutableAttributedText.length), | ||
| options: [] | ||
| ) { value, range, _ in | ||
| if let link = value as? URL { |
Collaborator
There was a problem hiding this comment.
Is possible replace if-let by guard for avoiding pyramid of doom?
| } | ||
|
|
||
| static func findEmbeddedLinks(in textMessageData: TextMessageData) -> [NSTextCheckingResult] { | ||
| if let originalURLString = textMessageData.linkPreview?.originalURLString, |
Collaborator
There was a problem hiding this comment.
Is possible replace if-let by guard ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Embedded links are not detected and underlined
See ticket for example
Testing
Please test with embedded links and see if underline is applied
Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: