Skip to content

fix: EAR Security Tests - WPB-23474 🍒#4465

Open
github-actions[bot] wants to merge 3 commits intodevelopfrom
fix/ear-security-tests-cherry-pick-cherry-pick
Open

fix: EAR Security Tests - WPB-23474 🍒#4465
github-actions[bot] wants to merge 3 commits intodevelopfrom
fix/ear-security-tests-cherry-pick-cherry-pick

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 20, 2026

TaskWPB-23474 [iOS] Fix EAR user session security tests

This PR was automatically cherry-picked based on the following PR:

Original PR description:


This PR was automatically cherry-picked based on the following PR:

Original PR description:


Issue

In #4299 I disabled some of the tests covering the EARService integration in the ZMUserSession because the asynchronous init of EARService wasn't compatible with the synchronous setup methods of SessionManagerEncryptionAtRestMigrationTests and ZMUserSessionTests_EncryptionAtRest.

To solve this issue, I've introduced a EARServiceFactory that keeps the capability of creating a EARService instance in an async manner for production code, while adding an interface that allows tests to create an EARService instance synchronously, coupled with a subsequent async setup method. This allows the synchronous setup methods to create the service.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

Co-authored-by: David-Henner <david.henner@wire.com>
@David-Henner David-Henner enabled auto-merge March 20, 2026 16:13
@netbe netbe changed the title fix: EAR Security Tests - WPB-23474 🍒 🍒 fix: EAR Security Tests - WPB-23474 🍒 Mar 24, 2026
Copy link
Collaborator

@zenkins zenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved cherry-pick PR 🍒.

@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 24, 2026

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit e365404.

♻️ This comment has been updated with latest results.

Summary: workflow run #23543657501
Allure report (download zip): html-report-28788-fix_ear-security-tests-cherry-pick-cherry-pick

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍒

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants