fix: sent indicator way off on shared file (image/video) - WPB-23929

[jullianm]

WPB-23929 [iOS][Files in conversation] Send indicator appears much below the video in conversation for the sender

Issue

This PR fixes a layout issue on some shared file (image/video) where the height of the custom FlowLayout is not properly computed resulting in a sent indicator looking way off (see screenshots)

BEFORE

AFTER

Testing

Describe how to test.

Optional: attachments like images, videos, etc.

---

Checklist

• Title contains a reference JIRA issue number like [WPB-XXX].
• Description is filled and free of optional paragraphs.
• Adds/updates automated tests.

---

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

• Make sure you use the API for UI elements that support large fonts.
• All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
• New UI elements have Accessibility strings for VoiceOver.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

2 140 tests   2 113 ✅  2m 33s ⏱️
  353 suites     27 💤
    2 files        0 ❌

Results for commit dc6dd53.

♻️ This comment has been updated with latest results.

Summary: workflow run #23538132469
Allure report (download zip): html-report-28778-fix_sent-indicator-way-off-on-shared-file

[datadog-wireapp]

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

🧪 1 Test failed

testThatItRendersLinkPreviewMessagePreview() from Wire-iOS-Tests.MessageReplyPreviewViewTests     (Fix with Cursor)

Test crashed with signal segv.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: dc6dd53 | Docs | Was this helpful? Give us feedback!}

[samwyndham]

@jullianm Please check that this doesnit break other places that the flow layout is used are not broken - I'm thinking especially sending/receiving multiple files.

[WilhelmOks]

@jullianm Please check that this doesnit break other places that the flow layout is used are not broken - I'm thinking especially sending/receiving multiple files.

That's a good point.

I was curious and checked where FlowLayout is being used.

It's not used by the file upload (drafts). Instead, it uses an HStack within a horizontal ScrollView.

The other places where it's used are only the two Views where we show the tags. I checked it in the SwiftUI Preview and it looked fine.

Interestingly, we also have unit tests for the FlowLayout. But sadly they didn't catch the issue with the wrong size calculation.
Maybe it would be a good idea to add a unit test to check for this and prevent that kind of regression in the future.

[jullianm]

@samwyndham @WilhelmOks checked the various places where flow layout is used and it looks fine.