Skip to content

Conversation

@zskhan
Copy link
Contributor

@zskhan zskhan commented Jan 2, 2026

TaskWPB-21195 [Web] Calling - "Share screen" button without value

Pull Request

Summary

Add role and aria attributes for screen sharing toggle accessibility

  • What did I change and why?
  • Risks and how to roll out / roll back (e.g. feature flags):

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2026

@zskhan zskhan enabled auto-merge (squash) January 2, 2026 09:41
@zskhan zskhan merged commit 3a44242 into dev Jan 2, 2026
39 of 46 checks passed
@zskhan zskhan deleted the feat/update-screen-share-button-value branch January 2, 2026 09:43
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.62%. Comparing base (9dee47f) to head (96910a8).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #19956      +/-   ##
==========================================
- Coverage   44.62%   44.62%   -0.01%     
==========================================
  Files        1311     1311              
  Lines       33029    33029              
  Branches     7315     7315              
==========================================
- Hits        14740    14739       -1     
  Misses      16539    16539              
- Partials     1750     1751       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 100
  • Failed: 9
  • Skipped: 11
  • 🔁 Flaky: 9
  • 📊 Total: 129
  • Total Runtime: 375.5s (~ 6 min 15 sec)
specs/Accessibility/Accessibility.spec.ts (❌ 1 failed, ⚠️ 2 flaky)
  • ❌ Accessibility > I want to see collapsed view when app is narrow (tags: TC-48, regression)
  • ⚠️ Accessibility > I want to see typing indicator in group conversation (tags: TC-46, regression)
  • ⚠️ Accessibility > I should not lose a drafted message when switching between conversations in collapsed view (tags: TC-51, regression)
specs/AccountSettingsSpecs/accountSettings.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ account settings > I should not be able to change email of user managed by SCIM (tags: TC-60, regression)
specs/AppLock/AppLock.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ AppLock > Web: App should not lock if I switch back to webapp tab in time (during inactivity timeout) (tags: TC-2752, TC-2753, regression)
specs/ArchiveSpecs/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Accessibility > I want to archive the 1on1 conversation from conversation details (tags: TC-105, regression)
specs/Authentication/authentication.spec.ts (❌ 1 failed, ⚠️ 1 flaky)
  • ❌ Authentication > Make sure user does not see data of user of previous sessions on same browser (tags: TC-1311, regression)
  • ⚠️ Authentication > Verify current browser is set as temporary device (tags: TC-3460, regression)
specs/Block/block.spec.ts (❌ 1 failed, ⚠️ 1 flaky)
  • ❌ Block: User A and User B are NOT in the same team > Verify you can block a user who is not in your team (tags: TC-140, regression)
  • ⚠️ Block: User A and User B are in the same team > Verify you can not block a user from your team (tags: TC-8778, regression)
specs/CriticalFlow/accountManagement-TC-8639.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Account Management (tags: TC-8639, crit-flow-web)
specs/CriticalFlow/Cells/uploadingFileInGroupConversation.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Uploading an file in a group conversation (tags: crit-flow-cells, regression)
specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ 1:1 Video call with device switch and screenshare (tags: TC-8754, crit-flow-web)
specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Personal Account Lifecycle (tags: TC-8638, crit-flow-web)
specs/Edit/edit.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Edit > I cannot edit another users message (tags: TC-683, regression)
specs/RegressionSpecs/block-messages.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Block specs (tags: TC-141, regression)
specs/Reply/reply.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Reply > I should not be able to send a reply after I got removed from the conversation (tags: TC-3014, regression)
specs/SelfDeletingMessages/selfDeletingMessages.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Self Deleting Messages > Verify sending ephemeral text message in 1:1 (tags: TC-657, regression)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants