-
Notifications
You must be signed in to change notification settings - Fork 298
chore(e2e): Added clearing of search input query to handle retries [WPB-21646] #20377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…rsationFiles.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rsation.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rsation.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rsation.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rsation.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sInGroupConversation-TC-8788.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sInGroupConversation-TC-8788.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sInGroupConversation-TC-8788.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sInGroupConversation-TC-8788.spec.ts Co-authored-by: Mark Brockhoff <95471369+markbrockhoff@users.noreply.github.com>
…rsation-TC-8788.spec.ts Co-authored-by: Mark Brockhoff <95471369+markbrockhoff@users.noreply.github.com>
…rsation-TC-8788.spec.ts Co-authored-by: Mark Brockhoff <95471369+markbrockhoff@users.noreply.github.com>
…rsation-TC-8788.spec.ts Co-authored-by: Mark Brockhoff <95471369+markbrockhoff@users.noreply.github.com>
…rsation-TC-8788.spec.ts Co-authored-by: Mark Brockhoff <95471369+markbrockhoff@users.noreply.github.com>
…rsation.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rsation.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds/updates Drive-related Playwright E2E coverage to improve reliability around searching files in a Cells-enabled group conversation (WPB-21646), including support utilities/page objects to make the assertions and retries more robust.
Changes:
- Added a new E2E spec for searching files in a group conversation (TC-8788), including clearing the search query between checks.
- Updated Cells page objects to support file search and multipart (image/video) asset locators; adjusted existing Drive specs accordingly.
- Minor E2E maintenance: export
VideoFileName, fix fixtures import paths in Drive specs, and correct the README env-inject command path.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/webapp/test/e2e_tests/utils/asset.util.ts | Exports VideoFileName for reuse in specs. |
| apps/webapp/test/e2e_tests/specs/Drive/uploadingFileInGroupConversation-TC-8785.spec.ts | Fixes fixtures import path; improves assertions/selectors and tags. |
| apps/webapp/test/e2e_tests/specs/Drive/searchFilesInGroupConversation-TC-8788.spec.ts | New spec covering file search in group conversation + query clearing. |
| apps/webapp/test/e2e_tests/specs/Drive/replyingToMultipartMessage-TC-8787.spec.ts | Fixes fixtures import path. |
| apps/webapp/test/e2e_tests/specs/Drive/editMultipartMessage-TC-8786.spec.ts | Fixes fixtures import path. |
| apps/webapp/test/e2e_tests/pageManager/webapp/pages/conversation.page.ts | Makes getImageLocator public for direct test assertions. |
| apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversationFiles.page.ts | Adds search input locator + searchFile(); replaces click helper with getFile(). |
| apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversation.page.ts | Refines image locator strategy; adds multipart image/video locators. |
| apps/webapp/test/e2e_tests/README.md | Updates op inject paths to match repo structure. |
| await expect(userBPages.cellsConversationFiles().filesList).toHaveCount(1, {timeout: 500}); | ||
| await expect(userBPages.cellsConversationFiles().getFile(VideoFileName)).toBeVisible({timeout: 500}); |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Important] - The retry block uses very short per-assertion timeouts (500ms) immediately after filling the search input. In the app, file search is debounced (300ms) and requires a network request, so 500ms can be too tight and make this test flaky even when indexing is fine.
Consider removing the {timeout: 500} overrides (use default expect timeouts) or increasing them while keeping the outer .toPass({timeout: ...}) as the overall cap.
| await expect(userBPages.cellsConversationFiles().filesList).toHaveCount(1, {timeout: 500}); | |
| await expect(userBPages.cellsConversationFiles().getFile(VideoFileName)).toBeVisible({timeout: 500}); | |
| await expect(userBPages.cellsConversationFiles().filesList).toHaveCount(1); | |
| await expect(userBPages.cellsConversationFiles().getFile(VideoFileName)).toBeVisible(); |
| export class CellsConversationFilesPage { | ||
| readonly page: Page; | ||
| readonly filesList: Locator; | ||
| filesList: Locator; |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] - filesList was changed from readonly to mutable, but it’s never reassigned after construction.
Keeping it readonly prevents accidental reassignment and matches the rest of the Page Object pattern in this folder.
| filesList: Locator; | |
| readonly filesList: Locator; |
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversationFiles.page.ts
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #20377 +/- ##
=======================================
Coverage 45.17% 45.17%
=======================================
Files 1633 1633
Lines 40241 40241
Branches 8324 8324
=======================================
Hits 18177 18177
Misses 20137 20137
Partials 1927 1927
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts (❌ 1 failed,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
|



Pull Request
Summary
https://wearezeta.atlassian.net/browse/WPB-21646
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers