feat: toggle apps in conversation creation [WPB-23669]#20501
Open
feat: toggle apps in conversation creation [WPB-23669]#20501
Conversation
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/CriticalFlow/conversationManagement-TC-8636.spec.ts (❌ 1 failed,
|
3460c3a to
45227bc
Compare
zskhan
reviewed
Feb 25, 2026
apps/webapp/src/script/components/Modals/GroupCreation/GroupCreationModal.tsx
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #20501 +/- ##
==========================================
- Coverage 45.38% 45.37% -0.01%
==========================================
Files 1637 1640 +3
Lines 40363 40373 +10
Branches 8333 8336 +3
==========================================
+ Hits 18319 18320 +1
- Misses 20108 20118 +10
+ Partials 1936 1935 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
121e7d1 to
2075ba2
Compare
e-maad
reviewed
Feb 26, 2026
Comment on lines
+161
to
+164
| const isAppsFeatureAvailable = | ||
| isTeam && | ||
| ((selectedProtocol.value == CONVERSATION_PROTOCOL.PROTEUS && teamState?.hasWhitelistedServices()) || | ||
| (selectedProtocol.value == CONVERSATION_PROTOCOL.MLS && isAppsEnabledForTeam)); |
Contributor
There was a problem hiding this comment.
We have this logic in two places, it is possible to keep it in a single places? A hook or reusable function?
zskhan
reviewed
Feb 26, 2026
apps/webapp/src/script/components/Note/AppsDisabledNote/AppsDisabledNote.tsx
Outdated
Show resolved
Hide resolved
…sabledNote.tsx Co-authored-by: Zafar Saeed Khan <zafarsaeed@outlook.com>
Co-authored-by: Zafar Saeed Khan <zafarsaeed@outlook.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request
Summary
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers