Skip to content

feat: toggle apps in conversation creation [WPB-23669]#20501

Open
panuschek wants to merge 7 commits intodevfrom
feat/toggle-apps-in-conversation
Open

feat: toggle apps in conversation creation [WPB-23669]#20501
panuschek wants to merge 7 commits intodevfrom
feat/toggle-apps-in-conversation

Conversation

@panuschek
Copy link
Collaborator

@panuschek panuschek commented Feb 24, 2026

StoryWPB-23669 [Web][Integrations] Toggle app slider at conversation creation

Pull Request

Summary

  • Toggles the availability of apps when creating channels or groups based on the default protocol and feature flags

Security Checklist (required)

  • [ X ] External inputs are validated & sanitized on client and/or server where applicable.
  • [ X ] API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • [ X ] No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • [ X ] Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 9
  • Failed: 1
  • Skipped: 4
  • 🔁 Flaky: 0
  • 📊 Total: 14
  • Total Runtime: 83.0s (~ 1 min 23 sec)
specs/CriticalFlow/conversationManagement-TC-8636.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Conversation Management (tags: TC-8636, crit-flow-web)

@panuschek panuschek force-pushed the feat/toggle-apps-in-conversation branch from 3460c3a to 45227bc Compare February 24, 2026 16:13
@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.37%. Comparing base (2b43bae) to head (2075ba2).

Files with missing lines Patch % Lines
...onversation/CreateConversationSteps/Preference.tsx 0.00% 4 Missing ⚠️
...onents/Modals/GroupCreation/GroupCreationModal.tsx 0.00% 3 Missing ⚠️
...s/webapp/src/script/components/Note/Note.styles.ts 0.00% 3 Missing ⚠️
...ponents/Note/AppsDisabledNote/AppsDisabledNote.tsx 0.00% 2 Missing ⚠️
apps/webapp/src/script/components/Note/Note.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #20501      +/-   ##
==========================================
- Coverage   45.38%   45.37%   -0.01%     
==========================================
  Files        1637     1640       +3     
  Lines       40363    40373      +10     
  Branches     8333     8336       +3     
==========================================
+ Hits        18319    18320       +1     
- Misses      20108    20118      +10     
+ Partials     1936     1935       -1     
Flag Coverage Δ
app_webapp 43.58% <0.00%> (-0.01%) ⬇️
lib_api_client 50.17% <ø> (ø)
lib_core 58.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...webapp/src/script/components/toggle/InfoToggle.tsx 77.77% <ø> (ø)
...ponents/Note/AppsDisabledNote/AppsDisabledNote.tsx 0.00% <0.00%> (ø)
apps/webapp/src/script/components/Note/Note.tsx 0.00% <0.00%> (ø)
...onents/Modals/GroupCreation/GroupCreationModal.tsx 0.00% <0.00%> (ø)
...s/webapp/src/script/components/Note/Note.styles.ts 0.00% <0.00%> (ø)
...onversation/CreateConversationSteps/Preference.tsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panuschek panuschek force-pushed the feat/toggle-apps-in-conversation branch from 121e7d1 to 2075ba2 Compare February 26, 2026 08:17
Comment on lines +161 to +164
const isAppsFeatureAvailable =
isTeam &&
((selectedProtocol.value == CONVERSATION_PROTOCOL.PROTEUS && teamState?.hasWhitelistedServices()) ||
(selectedProtocol.value == CONVERSATION_PROTOCOL.MLS && isAppsEnabledForTeam));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this logic in two places, it is possible to keep it in a single places? A hook or reusable function?

panuschek and others added 2 commits February 26, 2026 10:34
…sabledNote.tsx

Co-authored-by: Zafar Saeed Khan <zafarsaeed@outlook.com>
Co-authored-by: Zafar Saeed Khan <zafarsaeed@outlook.com>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants