chore(types): enable strictNullChecks in base config with explicit null guards in server/config/core [WPB-23695]#20510
Merged
screendriver merged 1 commit intodevfrom Feb 26, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #20510 +/- ##
==========================================
+ Coverage 45.38% 45.40% +0.01%
==========================================
Files 1637 1637
Lines 40363 40364 +1
Branches 8333 8334 +1
==========================================
+ Hits 18319 18326 +7
+ Misses 20108 20101 -7
- Partials 1936 1937 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
a16fc87 to
e80066f
Compare
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
|
…ll guards in server/config/core - enable strictNullChecks in base TypeScript config - fix strict-null regressions in server, config-lib, and core-lib with explicit null/undefined checks (no implicit truthy/falsy checks in touched code) - improve unhandled rejection type logging with explicit type narrowing - add/update tests for new null-handling behavior: - client build date parsing when version is missing - server config defaults when URLs are missing - link preview audit upload with missing title - browser util test helper null safety - keep webapp temporarily opted out via local strictNullChecks: false override due to existing nullability backlog and unresolved module typing in webapp:type-check
e80066f to
9b58ce8
Compare
|
thisisamir98
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request
Summary
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers